add a couple of todos

alexjlockwood · Dec 1, 2017 · 7dead25 · 7dead25
1 parent aa97b2f
commit 7dead25
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/plugins/convertPathData.ts b/src/plugins/convertPathData.ts
@@ -48,7 +48,7 @@ export type Params = typeof defaultParams;
 function fn(item: JsApi, params: Params) {
   if (
     !(item.isElem('path') || item.isElem('clip-path')) ||
-    // TODO: properly reference the attribute using the correct namespace
+    // TODO: don't optimize the path if it has a name?
     !item.hasAttr('android:pathData')
   ) {
     return item;

diff --git a/src/plugins/removeEmptyGroups.ts b/src/plugins/removeEmptyGroups.ts
@@ -6,6 +6,7 @@ import { Plugin } from './_types';
  * TODO: are there any empty containers that could be removed in an animated-vector?
  */
 function fn(item: JsApi) {
+  // TODO: should we remove an empty group if it has a name? we could break an AVD...
   return item.isElem('group') && item.isEmpty() ? undefined : item;
 }