Expose Client Class #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaoshuai0102
force-pushed
the
expose-client-class
branch
from
1d012b9 to
45dcbaf
Compare
|
I intentionally hide the Client class since it's an implementation detail and I want to have the flexibility to change it without breaking existing users. What kind of feature you plan to add? I may help you find a different way to do so. |
|
@alexguan I also need to extend it to create |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm writing a zookeeper plugin for egg.
It will be great if I can access the client class directly so I can extend it easily. Otherwise I gotta implement a proxy class delegating everything to the instance created by
zookeeper.createClient().