Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate human friendly error message #93

Merged
merged 3 commits into from
May 9, 2020
Merged

Generate human friendly error message #93

merged 3 commits into from
May 9, 2020

Conversation

chaosAD
Copy link
Contributor

@chaosAD chaosAD commented May 8, 2020 •
edited
Loading

I made 2 improvements:

  1. Added some code lines so that when the link to the Springer Excel file is broken, it generates a human friendly message with one extra info. This may prevent misunderstanding (HTTP Error 404 Not Found but I was able to manually download spreadsheet #89 and HTTP Error 404: Not Found #85) and can help user understand the problem encountered by printing out the faulty URL.
  2. Reduced the call to requests.get()

chaosAD added 3 commits May 9, 2020 01:10
@chaosAD
Reduce the call to requests.get()
a57be56 
It doesn't improve the speed, but it combines 2
functions to 1
@chaosAD
Added code to generate better error message
02b3339 
When the link to the Springer Excel file is broken,
it generates human friendly message.
@chaosAD
Modified the HTTPError message
b663de2
alexgand
alexgand approved these changes May 9, 2020
View reviewed changes
Copy link
Owner

@alexgand alexgand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged, thanks!

@alexgand alexgand merged commit 854dd9b into alexgand:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgand alexgand alexgand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaosAD @alexgand