Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merge/release] Add commit message linting feature #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Mar 18, 2018

  1. Add commit message linting feature

    Adds feature to .DEREK.yml `commit_linting`, which when enabled
    lints commit messages with a style consistent with the guidelines
    written up by Chris Beams [1]. The linting will place a label on a PR
    and send a comment when it fails linting, but this is not blocking.
    
    The label used is: review/commit-message and that will be removed
    if and when the linting is fixed.
    
    Unit test coverage is added for the linting.
    
    The DCO checking feature was also tested and an optimization was
    added so that the PR labels are only fetched once and then re-used
    this is to save on API rate-limiting and server trips.
    
    [1] https://chris.beams.io/posts/git-commit/
    
    Signed-off-by: Alex Ellis <[email protected]>
    alexellis committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    976d8d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2018

  1. Expand linting of subject to 72 chars

    GitHub's UI will allow 72 chars so I've changed the code to use
    that as a hard limit instead of 50. The message still prefers 50
    characters.
    
    Also implements linting to prevent punctuation of (.!) given at
    end of subject line.
    
    Signed-off-by: Alex Ellis <[email protected]>
    alexellis committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    7efc5be View commit details
    Browse the repository at this point in the history
  2. Update description of linting rules with URL

    Signed-off-by: Alex Ellis <[email protected]>
    alexellis committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    05f9c28 View commit details
    Browse the repository at this point in the history