Neopixel performance improvements #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the array dimension was dependent on an associated constant but this opens up a portal to the Plane of Torment due to Rust's poor compositionality between const generics, associated consts, and trait parameter types. Now, the user is just expected to have these dimensions aligned.
This allows abstracting the number and order of neopixel color channels (e.g. RGBW, GRB, etc). It is now mandatory to supply a color layout when instantiating a Neopixel module.
In the Neotrellis 4x4 case, this is an 8x improvement in number of i2c transactions and seesaw i2c timeouts. Generic const exprs have been removed from the interface as they infect library user programs and are not completely implemented resulting in compiler crashes (normalization is not implemented).
|
I use this to run my 4 neotrellis 4x4 pad (8x8 total) driven by some esp32 at 125Hz with full display refresh and button reading (and still have some cycles for wifi and the kids' games). |
|
Hey @dsheets. I've put out two new versions: one that adds the |
|
Closing but happy to reopen if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #11, this enables driving a NeoTrellis 4x4 at a reasonable framerate by adding an API to perform bulk neopixel updates in a single transaction and reducing copying.