sfall: SpeedPatch, LoadGameHook (LoopFlag) #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janiczek
commented
Oct 16, 2022
Janiczek
force-pushed
the
feature/add-sfall-speed-patch
branch
from
87222f9 to
d23c849
Compare
c6-dev
reviewed
Oct 16, 2022
Janiczek
changed the title
Janiczek
force-pushed
the
feature/add-sfall-speed-patch
branch
3 times, most recently
from
2df2397 to
64ae27f
Compare
Janiczek
commented
Oct 18, 2022
Comment on lines
-2066
to
-2071
| // 0x48FC48 | ||
| int _do_options() | ||
| { | ||
| return showOptionsWithInitialKeyCode(-1); | ||
| } | ||
|
|
There was a problem hiding this comment.
A function with this code already exists, see line 462:
// 0x48FC48
int showOptions()
{
return showOptionsWithInitialKeyCode(-1);
}
Janiczek
commented
Oct 18, 2022
Comment on lines
+8
to
+13
| // True if game was started, false when on the main menu | ||
| bool mainIsGameLoaded(); | ||
| void mainSetIsGameLoaded(bool isGameLoaded); | ||
|
|
||
| bool mainIsInEndgameSlideshow(); | ||
| void mainSetIsInEndgameSlideshow(bool isInEndgameSlideshow); |
There was a problem hiding this comment.
I suppose these could also live in loop.h as extra flags? Depends how much we want to stay close to sfall, I guess. WDYT?
Janiczek
force-pushed
the
feature/add-sfall-speed-patch
branch
from
64ae27f to
220c30a
Compare
I'm pretty sure steal odds shouldn't be related to speed patch in any way. I've have researched that code last year when working on steal rebalance. It's just regular math and Fallout's RNG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds support ✅ for a subset of the sfall Speed patch:
It doesn't ❌ deal with the keybinding part:
It also, out of necessity, implements much of the
LoadGameHookflag tracking in a new fileloop.c. With this we now have an easy way to check whether eg. an inventory screen is open, etc.Proof of concept
vid.mp4
Approach taken
getTicks()to optionally multiply its resultLoadGameHooksfall module intoloop.cRelated links
LoadGameHook.h(definition ofLoopFlag)LoadGameHook.cppSpeedPatch.cppddraw.iniconfigPossible problems (maybe they are also problems on
main, and not caused by this patch?)From my gameplay it seems like critters (like eg. geckos in Toxic Caves) don't move (as in, walk and wander around) as often as in the original game (from my memory). They almost don't move at all. Maybe their movement runs on the original speed somehow? Maybe this is an issue in original+sfall SpeedPatch as well?Seen onmainas wellCompanions seem to only attack if the enemy is in range, they won't walk to them. (With the distance setting at "Charge!")In the end they do move towards the enemies, it's just not always.