Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathJax, registration support, flask-bcrypt & updated view permissions #82

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mjiao5151
Copy link

Dear friend:
I really like your work on this wiki app, reading your code have been a great learning experience.
I feel thrilled to contribute to this project.
the following are few modifications, hope it can fit your appetite.

  1. add mathjax support, by using python-markdown-math extension.
  2. add Registration form and corresponding template file
  3. use bcrypt package to do the password encryption, save few lines of code.
  4. modified view function permissions.

Hope that help!

@lordslair
Copy link

lordslair commented Apr 14, 2020

Hello everyone,

Just to drop a comment here, as I tried the original repo, and the PR proposed by @mjiao5151
I spawned his branch inside a container to check it, and as far as I can see, everything's working out-of-the-box without any problem.

I don't know if it will be merged into master, but it made me save a lot of time, as I needed that feature

Thanks to both of you

@alexanderjulo alexanderjulo changed the title Pull request MathJax, registration support, flask-bcrypt & updated view permissions Nov 2, 2020
alexanderjulo added a commit that referenced this pull request Nov 23, 2020
@alexanderjulo
Copy link
Owner

Hey @mjiao5151,

thanks a lot for these changes! I broke out mathjax in a separate PR (with the only change being that I checked in the JS, to make sure it will work offline also) and I will be merging it.

I also like the bcrypt change, however I believe it will not be backwards compatible. So I will technically have to issue a major release and add some release notes to make sure that people know what might have happened. I will do so some time next month.

alexanderjulo added a commit that referenced this pull request Nov 23, 2020
@tieugene tieugene mentioned this pull request Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants