Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old Pull Request - Ignore #41

Closed
wants to merge 1 commit into from
Closed

Old Pull Request - Ignore #41

wants to merge 1 commit into from

Conversation

Pluckerpluck
Copy link

Due to potential changes... please don't pull this (at least not yet)

If you pull this into live remember to change your config file

This will cause DeltaBot to check to see if a comment was written by the submissions author (OP has replied). If they have AND the no_replies_flair is the current flair then it shall be removed.

This is the first step to potentially using this system. The next step would be to have some way to flair submissions older than a particular ages (the easiest being 0 seconds old). This is a bit more complex to add and I don't have too much time right now.

As long as no_replies_flair is set to something unused in the config then this change should do nothing and can sit idly until this is used.

I thought I'd send the pull request now though ... to get the ball rolling.

Edit: I've realized that my double if statement can be changed to and "if and" statement. That's more preference than anything else.

This will cause DeltaBot to check to see if a comment was written by the
submissions author (OP has replied).

If they have AND the no_replies_flair is the current flair then it shall
be removed.
@amorde
Copy link
Contributor

amorde commented Jan 10, 2014

So what else needs to be done regarding this feature? This seems pretty complete to me unless I am missing something.

@Pluckerpluck
Copy link
Author

Oh it's missing a lot. I'd now suggest not pulling this change. The functionality they want to accomplish would probably be achieved in a different way than is being done here.

#6

The issue is found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants