Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait for lambda function state updates #423

Merged
merged 2 commits into from
Dec 27, 2021

Conversation

jsetton
Copy link
Contributor

@jsetton jsetton commented Dec 7, 2021

Issue #, if available:

Fixes: #415

Description of changes:

This change adds waiting for Lambda function state updates support which is now required per this blog post. The lambda-deployer workflow will now wait after each Lambda function operations (create, add event permission, update code and update configuration) while the function state and last update status are pending/in progress. Once these properties are available, the deployment workflow will only continue if the function state is Active and the last update status is Successful.

A fix for the Windows test integration is also included. The Windows image now runs Python 3.10 which is breaking the Python build flow as it is currently only expecting single digit minor version.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sam-goodwin
Copy link

Thanks so much for donating your time to fix and test this. One last question: have you tested this change with a lambda that is opted in to States and on that is not?

@jsetton
Copy link
Contributor Author

jsetton commented Dec 7, 2021

One last question: have you tested this change with a lambda that is opted in to States and on that is not?

I tested with the default behavior which is opt-in at this point. Does the opt-out workaround still work? If so, I can give a try when I get back in front of a computer.

@jsetton
Copy link
Contributor Author

jsetton commented Dec 8, 2021

So the opt-out workaround still works. I was able to confirm that this fix works with the previous (opt-out) and the default (opt-in) behaviors.

@jsetton
Copy link
Contributor Author

jsetton commented Dec 16, 2021

@sam-goodwin any plan to merge this PR and create a new release?

@Shreyas-vgr
Copy link
Contributor

Thanks @jsetton for the PR, I will merge this and release a new CLI version asap.

@Shreyas-vgr Shreyas-vgr merged commit b08093b into alexa:develop Dec 27, 2021
@jsetton jsetton deleted the lambda-state-update-fix branch December 27, 2021 23:32
@jsetton jsetton restored the lambda-state-update-fix branch December 27, 2021 23:32
@jsetton jsetton deleted the lambda-state-update-fix branch December 28, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get "ResourceConflictException" after opt-in AWS lambda states update
3 participants