Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add noElectronStart CLI option to the dev command #578

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erikian
Copy link

@erikian erikian commented Aug 1, 2024

Description

This adds an option to not start the Electron app after the dev server is up.

Additional context

The main motivation is being able to run Playwright tests faster; this would make it possible to use electron-vite to run the dev server and configure Playwright to run in development mode using that server, instead of having to bundle the entire project beforehand (which takes too long if you just want to run a one-off test to validate the code you're currently working on).


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

@erikian erikian force-pushed the feat/dev-noElectronStart-option branch from 402b22f to 05fd155 Compare August 1, 2024 02:24
@erikian erikian force-pushed the feat/dev-noElectronStart-option branch from 05fd155 to 03936a3 Compare August 1, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant