Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: wrong number for nested titles in TOC; add number for mobile TOC #555

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

loikein
Copy link
Contributor

@loikein loikein commented Aug 27, 2023

A screenshot of the bug can be found here: (I have already fixed it in the links)
Fix TOC numbering issue · Issue #3 · loikein/hugo-book

Cheers!

@loikein
Copy link
Contributor Author

loikein commented Sep 21, 2023

Hi @alex-shpak, would you like to review this PR? Thank you!

@alex-shpak
Copy link
Owner

alex-shpak commented Dec 4, 2023

Hi! Sorry for long response.
I'm checking your pr now, 2 questions:

  1. do you have a markdown snippet that I can use to reproduce such output?
  2. my gut feeling tells that #TableOfContents ul does not affect something, as previous selector covers as well

@loikein
Copy link
Contributor Author

loikein commented Dec 5, 2023

Hi Alex, thanks for replying.

My site repo before the fix take effect is here: https://github.com/loikein/wiki/tree/c561b0fd339017acfc4a95df60c1e111cabdf37a (with the theme as a submodule in the themes folder)
And the particular page in that screenshot is: https://github.com/loikein/wiki/blob/c561b0fd33/content/computer/software-usage/obsidian/index.md

The #TableOfContents ul, if my memory serves, was a quick way of capturing the mobile TOC without having to alter the style. Currently, the mobile TOC does not have numbers even when the numbered plugin was enabled.

@alex-shpak alex-shpak closed this Oct 1, 2024
@alex-shpak alex-shpak reopened this Oct 4, 2024
@alex-shpak alex-shpak merged commit 15c85ac into alex-shpak:master Oct 4, 2024
6 checks passed
Hanekihyouka pushed a commit to Hanekihyouka/hugo-book that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants