-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(search): searchDataURL must not use relative URL #505
base: master
Are you sure you want to change the base?
Conversation
There's already pending PR (alex-shpak#505), but this isn't approved somehow. Creating my own just for easier tracking.
Looks like we need to update search-data.js as well. Otherwise, we cannot click the outcome of the search results ( |
We have a similar issue with publishing our documentation on GitHub pages. As a workaround, we are using the following patch:
And running patch -p0 < patch_book.txt @rluders can you update the PR to apply changes on |
Any news about it? |
Someone can take this PR, adjust it, and create a new PR with the update. I'm a little bit busy to get it rebased and adjusted now. |
Hello! Sorry for a long waiting. Changing this will likely cause someone else to come and ask to change it back :) |
So after a bit of research, I have found that
Having that said:
|
Thanks for spending time on the research, so far I always tried to use only Option perhaps to have a parameter to switch |
This basically allows the
flexsearch
to work when you have a suffix at your Hugo hosting, like:https://<user>.pages.domain.com/<repository>
It always will load the data using the
$searchData.Permalink
instead using the$searchData.RelPermalink
.Fixes #363