Antonyjin upgrade pydantic version #293
Conversation
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #293 +/- ##
==========================================
- Coverage 61.60% 61.45% -0.15%
==========================================
Files 18 18
Lines 3183 3194 +11
Branches 448 448
==========================================
+ Hits 1961 1963 +2
- Misses 984 991 +7
- Partials 238 240 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Aleph-message and sdk now uses pydantic v2 but no released yet Using the github link atm and wait for the release.
When upgrading the pydantic version, some function are / will become deprecated. replacing them in those files.
Added `default=extended_json_encoder` to `json.dumps()` to handle serialization of non-native JSON types, such as dates and other complex objects. Replacing function that are / will be deprecated in pydantic v2 and v3
Pydantic>=2 is not compatible with fastapi<0.100.0
Conflit between pydantic and yamlfix black did not pass
With Pydantic v2, strict type validation is enforced. The type field is expected to have the exact value "POST" as a literal.
Antonyjin
force-pushed
the
antonyjin-upgrade-pydantic-version
branch
from
8f522ba to
e621718
Compare
- Unused varible deleted
- Replacing parse_obj() by model_validate() - Replacing copy() by model_copy() - Replacing dict() by model_dump()
…cause of some changes on aleph_message Before any change, there were classes dedicated to the size of Ephemeral and Persistent class such as PersistentVolumeSizeMb and EphemeralVolumeSizeMb. Now, the size is included inside the classes EphemeralVolume and PersistentVolume so have to access the size by another method. - Creating a function to get the max and min size, that way it is more rigorous - Calling this function to get max and min size of the different volumes
- Refactor the Dict() class inside the mocks test file to allow any key-value pair to be passed to the model.
|
Failed to retrieve llama text: POST 500: Traceback (most recent call last): The above exception was the direct cause of the following exception: Traceback (most recent call last): |
Arnaud made some changes about getting hashes that were better but I deleted by mistakes Putting back his code
This issue aims to upgrade the pydantic version to v2.
Related Jira tickets : ALEPH-149
Self proofreading checklist
Changes
Many functions will be deprecated using pydantic v2 and completly unusable when using pydantic v3. So all of them have been replaced with the good ones.
How to test
hatch run testing-test-cov
Notes
At the moment, aleph-message and aleph-sdk-python version use the github link. We need to wait the release of these two repositories and then put the right version instead of the github URL