Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ru and uk lang #733

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add ru and uk lang #733

wants to merge 4 commits into from

Conversation

wpdew
Copy link

@wpdew wpdew commented Mar 29, 2024

No description provided.

alefragnani
alefragnani requested changes Mar 31, 2024
View reviewed changes
Copy link
Owner

@alefragnani alefragnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wpdew ,

First of all, thank you for your contribution.

I would ask you to remove those .DS_Store files from the PR, as these are MacOS specific, and have no use in the project.

Also, I'm not sure you are aware of, but there are two other kind of resources for translations, if you are open to.

  • package.nls.XX.json file: commands, menus and settings
  • walkthrough\someMarkdown.nls.XX.md files: walkthrough steps

Thank you.

.DS_Store Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove this file from the PR.

src/.DS_Store Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove this file from the PR.

@alefragnani alefragnani self-assigned this Mar 31, 2024
@alefragnani alefragnani added enhancement PR needs update The PR needs review by the author translation Anything related to multi language support labels Mar 31, 2024
@alefragnani alefragnani added this to the Backlog milestone Mar 31, 2024
@wpdew
Copy link
Author

wpdew commented Apr 3, 2024

I don't see it in the project files - walkthrough\someMarkdown.nls.XX.md
Perhaps I'm missing something?

@alefragnani
Copy link
Owner

Hi @wpdew ,

This is just an example. You may notice a few (6) markdown files following the pattern *.nls.??.md, like saveYourFavoriteProjects.nls.pt-br.md. You just need to create a .ru and .uk equivalent, like saveYourFavoriteProjects.nls.ru.md. Look at #735 as an example.

Thank you

alefragnani
alefragnani reviewed Apr 3, 2024
View reviewed changes
vscode-project-manager-core
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file/reference can't be deleted. Please revert

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete PR fils?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both vscode-project-manager-core and vscode-whats-new files can't be deleted, because they refers to the git submodules. I guess you accidentally deleted these, while deleting the .DS_Store files.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change, to bring back the submodule files

alefragnani
alefragnani reviewed Apr 3, 2024
View reviewed changes
vscode-whats-new
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file/reference can't be deleted. Please revert

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This revert dor w do you ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both vscode-project-manager-core and vscode-whats-new files can't be deleted, because they refers to the git submodules. I guess you accidentally deleted these, while deleting the .DS_Store files.

Revert this change, to bring back the submodule files

alefragnani
alefragnani requested changes Apr 3, 2024
View reviewed changes
Copy link
Owner

@alefragnani alefragnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those files/references can't be deleted. Please revert. I'm not sure they were removed by the .gitignore changes you made.

@alefragnani alefragnani modified the milestones: Backlog, Next Release Apr 3, 2024
@alefragnani
Copy link
Owner

If you have any issues to revert these changes, you could close this PR and open a new one, simply adding the l10n files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EstefanyDominguezManzano EstefanyDominguezManzano EstefanyDominguezManzano left review comments

@alefragnani alefragnani alefragnani requested changes

Assignees

@alefragnani alefragnani

Labels
enhancement PR needs update The PR needs review by the author translation Anything related to multi language support
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
3 participants
@wpdew @alefragnani @EstefanyDominguezManzano