Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported Python version #139

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

youpong
Copy link
Contributor

@youpong youpong commented Oct 10, 2024

Description

Update supported Python versions.

  • support 3.13
  • discontinue support for 3.10

pandas has also been upgraded to support Python 3.13.

Related Issue(s)

User-facing Changes

Update Python version if necessary.

Screenshots (If necessary)

None.

@youpong youpong requested a review from alec-kr as a code owner October 10, 2024 14:07
@youpong
Copy link
Contributor Author

youpong commented Oct 10, 2024

Failed automated tests are not relevant to this Pull Request. See Issue #140.

@alec-kr
Copy link
Owner

alec-kr commented Oct 11, 2024

After reviewing the changes, it looks like some of the tests are failing due to an issue with the TestGetConstructors.test_get_constructors. Specifically, the current API response is returning only 100 constructor records, which is different from previous behavior.

While this issue is not directly related to your updates, I'm leaning towards merging your PR to keep the project dependencies up-to-date, as it's important to stay current with security patches and new features.

Copy link
Owner

@alec-kr alec-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@alec-kr alec-kr merged commit bb72eea into alec-kr:main Oct 11, 2024
4 of 13 checks passed
@youpong youpong deleted the update-python13 branch October 13, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants