Add 'USA' to the list of aliases #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does two things, and while I am reluctant but indifferent about the actual purpose, the additional changes I definitely do not accept. |
|
@alcohol I can split this PR on two parts, which can be reviewed separately. "Additional" changes allows lookup for country names like "Cote d’Ivoire" with regular ASCII characters, without symbols like "ô" (I don't even have this character in my keyboard layout). |
This reverts commit 9e424eb.
|
@alcohol I reverted changes for lookup the country names in ASCII. So current PR is very simple, although I still plan to suggest ASCII lookup in another separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of aliases is obviously missing the USA. Please include! Thanks!