Support for license and tests addition #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assafShapira
suggested changes
Jul 13, 2021
| image: | ||
| source: Sales | ||
| kaudit: "gcr.io/dcvisor-162009/alcide/dcvisor/kaudit:latest" | ||
| kaudit: "gcr.io/dcvisor-162009/alcide/dcvisor/kaudit-testing:license-test" |
There was a problem hiding this comment.
this one should be set back to "latest"
| kinesisStreamName: "" # AWS Kinesis stream name (for EKS) | ||
| region: "" # AWS Kinesis stream region (for EKS and S3) | ||
| region: "" # AWS Kinesis stream region (for EKS and S3) | ||
|
|
||
| accessKeyId: "" # AWS Kinesis stream credentials (for EKS and S3) |
There was a problem hiding this comment.
please add a comment with explanation regarding the use of credentials
key ID and secret OR iam role. but not both
if both are configured, what happens?
There was a problem hiding this comment.
OK, I haven't tested what will happen if both are included - I can add a test the throws a compeletion error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.