Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(middleware): create a generic middleware to collect method metrics. #804

Merged
merged 10 commits into from
Sep 26, 2024
Merged

feat(middleware): create a generic middleware to collect method metrics. #804

merged 10 commits into from
Sep 26, 2024

Conversation

andysim3d
Copy link
Collaborator

@andysim3d andysim3d commented Sep 19, 2024 •
edited
Loading

[Closes/Fixes] #787

Proposed Changes

@andysim3d andysim3d marked this pull request as draft September 19, 2024 20:16
@andysim3d andysim3d marked this pull request as ready for review September 23, 2024 19:17
andysim3d
andysim3d commented Sep 23, 2024
View reviewed changes
crates/task/src/metriclayer.rs Outdated Show resolved Hide resolved
crates/task/src/metriclayer.rs Outdated Show resolved Hide resolved
crates/task/src/metriclayer.rs Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Sep 23, 2024
View reviewed changes
crates/rpc/src/task.rs Outdated Show resolved Hide resolved
dancoombs
dancoombs reviewed Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also be able to implement this for Alloy in the provider crate

@andysim3d
Copy link
Collaborator Author

You should also be able to implement this for Alloy in the provider crate

yup I will do that in other pr. git won't allow me to split commits into multiple prs.

@dancoombs
Copy link
Collaborator

You should also be able to implement this for Alloy in the provider crate

yup I will do that in other pr. git won't allow me to split commits into multiple prs.

What do you mean? You should be able to add it to this PR?

@andysim3d
Copy link
Collaborator Author

You should also be able to implement this for Alloy in the provider crate

yup I will do that in other pr. git won't allow me to split commits into multiple prs.

What do you mean? You should be able to add it to this PR?

I can - but prefer small prs.

@dancoombs
Copy link
Collaborator

Few last comments, but other than that LGTM! Will ✅ after the small updates.

dancoombs
dancoombs approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it 🚢

@andysim3d andysim3d merged commit c96b09f into feat/v0.4 Sep 26, 2024
3 of 7 checks passed
@andysim3d andysim3d deleted the andy/metric-middle-ware branch September 26, 2024 15:26
dancoombs pushed a commit that referenced this pull request Oct 18, 2024
@andysim3d @dancoombs
feat(middleware): create a generic middleware to collect method metri…
9b54578 
…cs. (#804)
dancoombs pushed a commit that referenced this pull request Oct 23, 2024
@andysim3d @dancoombs
feat(middleware): create a generic middleware to collect method metri…
4147d28 
…cs. (#804)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dancoombs dancoombs dancoombs approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@0xfourzerofour 0xfourzerofour Awaiting requested review from 0xfourzerofour 0xfourzerofour is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andysim3d @dancoombs