fix: [CL ALCHEMY-001] validation applicability check in deferred action #278
+119
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: dcac37f |
|
Contract sizes: | Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|-------------------------------|------------------|-------------------|--------------------|---------------------|
| AccountFactory | 4,814 | 5,239 | 19,762 | 43,913 |
| AllowlistModule | 9,903 | 9,930 | 14,673 | 39,222 |
| ExecutionInstallDelegate | 5,714 | 5,760 | 18,862 | 43,392 |
-| ModularAccount | 21,973 | 28,676 | 2,603 | 20,476 |
+| ModularAccount | 21,931 | 28,634 | 2,645 | 20,518 |
| NativeFunctionDelegate | 434 | 461 | 24,142 | 48,691 |
| NativeTokenLimitModule | 4,449 | 4,476 | 20,127 | 44,676 |
| PaymasterGuardModule | 1,845 | 1,872 | 22,731 | 47,280 |
-| SemiModularAccountBytecode | 23,275 | 29,978 | 1,301 | 19,174 |
-| SemiModularAccountStorageOnly | 23,769 | 30,472 | 807 | 18,680 |
+| SemiModularAccountBytecode | 23,233 | 29,936 | 1,343 | 19,216 |
+| SemiModularAccountStorageOnly | 23,727 | 30,430 | 849 | 18,722 |
| SingleSignerValidationModule | 3,646 | 3,673 | 20,930 | 45,479 |
| TimeRangeModule | 2,000 | 2,027 | 22,576 | 47,125 |
| WebAuthnValidationModule | 7,854 | 7,881 | 16,722 | 41,271 |Code coverage:
|
OverviewOctane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉 🔗 Commit Hash: dcac37f |
howydev
approved these changes
Nov 8, 2024
adamegyed
force-pushed
the
adam/fix-deferred-action-validation-applicability
branch
from
8c57cdc
to
dcac37f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Addresses CL ALCHEMY-001.
In
_validateDeferredActionAndSetNonce, the incorrect validation applicability checking function was used, which only verified the selector, rather than considering the allowed pattern of batching using self-calls.Note that we can't adopt the suggested remediation due to the requirement of supporting calls to
approveon token contracts during a user op with initcode. See this test file for a sample case: https://github.com/alchemyplatform/modular-account/blob/develop/test/account/DeferredAction.t.sol#L61.Solution
Update the deferred action checking logic to use
_checkIfValidationAppliesCallData, which performs the necessary checks over self-calls.Also add a test verifying that the validation applicability check for self-calls is enforced.