feat: deferred install gas benchmarks #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: 469cc79 |
OverviewOctane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉 🔗 Commit Hash: 1467bb5 |
|
Contract sizes: | Contract | Size (B) | Margin (B) |
|------------------------------|----------|------------|
| AccountFactory | 4,169 | 20,407 |
| AllowlistModule | 5,817 | 18,759 |
| ERC20TokenLimitModule | 4,138 | 20,438 |
| ModularAccount | 25,983 | -1,407 |
| SemiModularAccount | 26,487 | -1,911 |
| SingleSignerValidationModule | 3,444 | 21,132 |
| TimeRangeModule | 1,870 | 22,706 |
| TokenReceiverModule | 2,189 | 22,387 |Code coverage:
|
adamegyed
reviewed
Sep 24, 2024
Zer0dot
force-pushed
the
zer0dot/deferred-install-benchmark
branch
from
68dffc5
to
50b7c06
Compare
adamegyed
approved these changes
Sep 26, 2024
Comment on lines
12
to
17
|
|
||
| import {ValidationConfig, ValidationConfigLib} from "../../src/libraries/ValidationConfigLib.sol"; | ||
| import {SingleSignerValidationModule} from "../../src/modules/validation/SingleSignerValidationModule.sol"; | ||
|
|
||
| import {ModuleSignatureUtils} from "../../test/utils/ModuleSignatureUtils.sol"; | ||
| import {BenchmarkBase} from "..//BenchmarkBase.sol"; | ||
|
|
There was a problem hiding this comment.
nit: forge fmt likes to randomly insert newlines when sorting imports, could we remove these? The fmt checker passes after removing these lines.
There was a problem hiding this comment.
Done! Wonder why the formatter does that..
| @@ -3,10 +3,12 @@ pragma solidity ^0.8.26; | |||
|
|
|||
| import {PackedUserOperation} from "@eth-infinitism/account-abstraction/interfaces/PackedUserOperation.sol"; | |||
| import {MessageHashUtils} from "@openzeppelin/contracts/utils/cryptography/MessageHashUtils.sol"; | |||
|
|
|||
| import {PackedUserOperation} from "@eth-infinitism/account-abstraction/interfaces/PackedUserOperation.sol"; | ||
| import {MessageHashUtils} from "@openzeppelin/contracts/utils/cryptography/MessageHashUtils.sol"; | ||
|
|
||
| import {ModuleEntity, ModuleEntityLib} from "../../src/libraries/ModuleEntityLib.sol"; | ||
| import {ValidationConfig, ValidationConfigLib} from "../../src/libraries/ValidationConfigLib.sol"; | ||
|
|
Co-authored-by: Adam Egyed <[email protected]>
Zer0dot
force-pushed
the
zer0dot/deferred-install-benchmark
branch
from
1467bb5
to
e5850ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Installing deferred validations will likely be a fairly high volume action. Benchmarking gas use for a simple case deferred validation grants us insights into gas consumption for this pretty common action.
Solution
Simply copy and lightly modify the standard test file (
DeferredValidation.t.sol) internal functions for deferred validation into the base benchmark gas contract (ModularAccountBenchmarkBase.sol.Then, add the gas tests for deferred validation for both the standard MA and the SMA with bytecode.