feat: add erc20 token limit module #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by OctaneNew Contracts
Updated ContractsNo contracts were updated in this PR. 🔗 Commit Hash: e4bce76 |
|
Contract sizes: | Contract | Size (B) | Margin (B) |
|------------------------------|----------|------------|
| AccountFactory | 4,169 | 20,407 |
+| ERC20TokenLimitModule | 4,138 | 20,438 |
| ModularAccount | 25,983 | -1,407 |
| SemiModularAccount | 26,487 | -1,911 |
| SingleSignerValidationModule | 3,444 | 21,132 |
| TokenReceiverModule | 2,189 | 22,387 |Code coverage:
|
This comment was marked as spam.
This comment was marked as spam.
adamegyed
reviewed
Sep 20, 2024
jaypaik
reviewed
Sep 23, 2024
fangting-alchemy
force-pushed
the
erc20
branch
from
ad9f9cf
to
67d2af7
Compare
fangting-alchemy
force-pushed
the
erc20
branch
3 times, most recently
from
6e41348
to
f0af33b
Compare
adamegyed
approved these changes
Sep 25, 2024
| import {UserOperationLib} from "@eth-infinitism/account-abstraction/core/UserOperationLib.sol"; | ||
| import {PackedUserOperation} from "@eth-infinitism/account-abstraction/interfaces/PackedUserOperation.sol"; | ||
|
|
||
| import {SetValue} from "@erc6900/modular-account-libs/libraries/AssociatedLinkedListSetLib.sol"; |
There was a problem hiding this comment.
With the refactor, this import and the _toSetValue internal function are no longer used.
|
|
||
| import {SetValue} from "@erc6900/modular-account-libs/libraries/AssociatedLinkedListSetLib.sol"; | ||
| import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol"; | ||
| import {EnumerableSet} from "@openzeppelin/contracts/utils/structs/EnumerableSet.sol"; |
There was a problem hiding this comment.
The EnumerableSet import and the using EnumerableSet for EnumerableSet.AddressSet; statement are both unused now and can be removed. I think the linter sees the using statement and thinks it is used, so it misses this case.
| return ""; | ||
| } | ||
|
|
||
| /// @inheritdoc IModule |
There was a problem hiding this comment.
Similar to the natspec comment requests for other modules, could you add the encoding format of data to natpspec as an @dev comment? This should help by making it show up in docs and on explorers.
fangting-alchemy
force-pushed
the
erc20
branch
from
f0af33b
to
dcc3ac4
Compare
fangting-alchemy
force-pushed
the
erc20
branch
from
dcc3ac4
to
0d54c95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Account holders may want to set ERC20 token spend limit to certain validations.
Solution
Create an ERC20 token limit module to offer hooks associated with validations that works with both UO and runtime call paths. See code doc for features and restrictions.