feat: Deferred Validation Installation #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zer0dot
force-pushed
the
zer0dot/deferred-validation-install
branch
from
4d980b3
to
23c298e
Compare
|
Contract sizes: | Contract | Size (B) | Margin (B) |
|------------------------------|----------|------------|
| AccountFactory | 4,763 | 19,813 |
| ERC1967Proxy | 104 | 24,472 |
| ModularAccount | 26,483 | -1,907 |
| SemiModularAccount | 27,540 | -2,964 |
| SingleSignerValidationModule | 3,444 | 21,132 |
| TokenReceiverModule | 2,189 | 22,387 |Code coverage:
|
|
By the way, the use of the |
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: 8f72474 |
Overview
Detailed findings
|
Zer0dot
force-pushed
the
zer0dot/deferred-validation-install
branch
from
ff550f2
to
21b45d0
Compare
adamegyed
reviewed
Sep 18, 2024
| validationFunction, deferredValidationInstallData, deferredInstallSig | ||
| ); | ||
|
|
||
| // Use a self-call to install the deferred validation. |
There was a problem hiding this comment.
question: can we use the internal _installValidation, or do we need to convert calldata types to memory types?
There was a problem hiding this comment.
so _installValidation() does do some calldata bytes slicing. It's possible to modify it to work internally in memory, but we might have efficiency loss in the standard installValidation() case. My thoughts were to just keep it simple and run a self-call. Wdyt?
There was a problem hiding this comment.
Ah yep, that's what I thought. The current approach makes sense, no need to do big refactors at the moment imo.
adamegyed
approved these changes
Sep 20, 2024
src/account/ModularAccount.sol
Outdated
| @@ -352,32 +369,151 @@ contract ModularAccount is | |||
| override | |||
| returns (uint256 validationData) | |||
| { | |||
| // Use outer validation as 1271 validation, then installed validation to validate the rest | |||
There was a problem hiding this comment.
tiny tiny nit: I think this comment only applies in the case where we're using the deferred validation install path, so could you move this comment to within the if (isDeferredInstallValidation) { block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to support flows like deferring session key installs until the first action that requires them.
Solution
During UO validation, use a specific (previously unused) bit in the signature field to indicate whether or not a deferred validation is necessary. If so, decode part of the signature field into the data needed to validate and install the inner validation. Note that the standard validation packing scheme (for the first 24 bytes of the signature) is, in this case, the validation used to validate the installation.
Post-installation, validate the user operation with the newly installed validation.