-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create): add performCreate[2] method. #168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this in! Some nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging that we're missing access control on these methods. In the past we could have used a modifier like wrapNativeFunction
, but we've removed that in this repo for code size optimization. We should wrap the two functions with the following:
(FunctionReference[][] memory postExecHooks, bytes[] memory postHookArgs) = _preNativeFunction();
// function body
_postNativeFunction(postExecHooks, postHookArgs);
I'll address in following pr. right now I am not sure the correct modifier to use here. |
Superseded for MAv2 by #192, closing this as it's targeting MAv1. Great work though Andy! |
Motivation
Enable
create
/create2
from ModularAccount.Solution