-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make demo readme more clear for new developers #974
Open
rthomare
wants to merge
1
commit into
main
Choose a base branch
from
rohan/chore/updateDemoReadme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rthomare
requested review from
moldy530,
dancoombs,
mokok123 and
dphilipson
as code owners
September 19, 2024 11:26
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rthomare
force-pushed
the
rohan/chore/updateDemoReadme
branch
from
September 19, 2024 11:28
572cc22
to
c446413
Compare
RobChangCA
approved these changes
Sep 20, 2024
moldy530
reviewed
Sep 23, 2024
Comment on lines
+14
to
+20
npm install | ||
# or | ||
yarn install | ||
# or | ||
pnpm install | ||
# or | ||
bun install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use yarn
everywhere so we should just have this be that
Comment on lines
+27
to
+33
npm build | ||
# or | ||
yarn build | ||
# or | ||
pnpm build | ||
# or | ||
bun build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
The focus of this PR is to update the
README.md
file in theui-demo
directory with detailed setup instructions for theaa-sdk
.Detailed summary