Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update eth_getUserOperationByHash response for pending status #311

Closed
wants to merge 2 commits into from

Conversation

avasisht23
Copy link
Contributor

@avasisht23 avasisht23 commented Dec 8, 2023

Pull Request Checklist


PR-Codex overview

This PR focuses on updating the UserOperationReceipt interface in the types.ts file.

Detailed summary

  • Updated blockNumber property to accept null if the user operation is pending.
  • Updated blockHash property to accept null if the user operation is pending.
  • Updated transactionHash property to accept null if the user operation is pending.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@avasisht23
Copy link
Contributor Author

@avasisht23 avasisht23 changed the title feat: update eth_getUserOperationByHash for pending status feat: update eth_getUserOperationByHash response for pending status Dec 8, 2023
@denniswon
Copy link
Contributor

should we update the doc for eth_getUserOperationByHash as well?

@avasisht23
Copy link
Contributor Author

avasisht23 commented Dec 11, 2023

should we update the doc for eth_getUserOperationByHash as well?

@denniswon there's no doc that goes to this level of granularity on the type (see the method doc).

Ava/Sahil are working getting types in and I'll let them know accordingly.

@denniswon
Copy link
Contributor

is this pr good to merge ? @avasisht23 @moldy530

@avasisht23
Copy link
Contributor Author

unsure if this is necessary anymore, closing

@avasisht23 avasisht23 closed this Mar 20, 2024
@avasisht23 avasisht23 deleted the avasisht23-patch-1 branch March 20, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants