Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nani-account #306

Merged
merged 6 commits into from
Dec 12, 2023
Merged

feat: add nani-account #306

merged 6 commits into from
Dec 12, 2023

Conversation

nerderlyne
Copy link
Contributor

@nerderlyne nerderlyne commented Dec 5, 2023

Pull Request Checklist


PR-Codex overview

Detailed summary

  • Added NaniAccountProviderConfig type in packages/accounts/src/nani-account/types.ts.
  • Exported NaniAccount and createNaniAccountProvider in packages/accounts/src/index.ts.
  • Created createNaniAccountProvider function in packages/accounts/src/nani-account/provider.ts.
  • Added getDefaultNaniAccountFactoryAddress utility function in packages/accounts/src/nani-account/utils.ts.
  • Defined NaniAccountFactoryConfigSchema and NaniAccountProviderConfigSchema in packages/accounts/src/nani-account/schema.ts.
  • Added NaniAccountFactoryAbi in packages/accounts/src/nani-account/abis/NaniAccountFactoryAbi.ts.
  • Added nani-account.ts snippet in site/snippets/nani-account.ts.
  • Added tests for NaniAccount in packages/accounts/src/nani-account/__tests__/account.test.ts.
  • Updated documentation in site/smart-accounts/accounts/nani-account.md.

The following files were skipped due to too many changes: site/smart-accounts/accounts/nani-account.md, packages/accounts/src/nani-account/account.ts, packages/accounts/src/nani-account/abis/NaniAccountAbi.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link
Collaborator

@moldy530 moldy530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits, but LGTM

packages/accounts/src/nani-account/account.ts Outdated Show resolved Hide resolved
@avasisht23 avasisht23 merged commit bf7566f into alchemyplatform:main Dec 12, 2023
2 checks passed
avasisht23 pushed a commit that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants