Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add particle to aa-signers #304

Merged
merged 5 commits into from
Dec 11, 2023

Conversation

avasisht23
Copy link
Contributor

@avasisht23 avasisht23 commented Dec 4, 2023

Pull Request Checklist


PR-Codex overview

This PR adds support for Particle authentication and signing methods to the ParticleSigner in the aa-signers package.

Detailed summary

  • Added ParticleSigner and ParticleAuthenticationParams to packages/signers/src/particle/index.ts
  • Added ParticleUserInfo interface to packages/signers/src/particle/types.ts
  • Updated site/.vitepress/config.ts to include documentation for ParticleSigner methods
  • Added @particle-network/auth and @particle-network/provider as dependencies in packages/signers/package.json
  • Added documentation for getAddress, signMessage, getAuthDetails, and signTypedData methods in site/packages/aa-signers/particle
  • Updated site/smart-accounts/signers/guides/particle-network.md to include setup instructions for ParticleSigner
  • Added createParticleSigner function in site/snippets/particle.ts
  • Added documentation for authenticate method in site/packages/aa-signers/particle/authenticate.md

The following files were skipped due to too many changes: site/packages/aa-signers/particle/authenticate.md, site/packages/aa-signers/particle/introduction.md, packages/signers/src/particle/signer.ts, packages/signers/src/particle/__tests__/signer.test.ts, site/packages/aa-signers/particle/constructor.md, yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@avasisht23
Copy link
Contributor Author

avasisht23 commented Dec 4, 2023

@avasisht23 avasisht23 mentioned this pull request Dec 4, 2023
7 tasks
@avasisht23 avasisht23 force-pushed the 12-03-feat_add_fireblocks_to_aa-signers branch from dee199a to ccdca68 Compare December 4, 2023 19:44
@avasisht23 avasisht23 force-pushed the 12-04-feat_add_particle_to_aa-signers branch from 971f81e to 87e8329 Compare December 4, 2023 19:44
@avasisht23 avasisht23 force-pushed the 12-03-feat_add_fireblocks_to_aa-signers branch from ccdca68 to e55a747 Compare December 4, 2023 21:57
@avasisht23 avasisht23 force-pushed the 12-04-feat_add_particle_to_aa-signers branch from 87e8329 to 8d51d6d Compare December 4, 2023 21:57
@avasisht23 avasisht23 marked this pull request as ready for review December 4, 2023 22:00
@avasisht23 avasisht23 mentioned this pull request Dec 5, 2023
7 tasks
Copy link
Contributor

@TABASCOatw TABASCOatw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for putting this together! Took a look and threw in a few comments.

site/packages/aa-signers/particle/authenticate.md Outdated Show resolved Hide resolved
site/packages/aa-signers/particle/authenticate.md Outdated Show resolved Hide resolved
site/packages/aa-signers/particle/authenticate.md Outdated Show resolved Hide resolved
site/packages/aa-signers/particle/constructor.md Outdated Show resolved Hide resolved
site/packages/aa-signers/particle/constructor.md Outdated Show resolved Hide resolved
site/packages/aa-signers/particle/constructor.md Outdated Show resolved Hide resolved
site/packages/aa-signers/particle/getAuthDetails.md Outdated Show resolved Hide resolved
site/packages/aa-signers/particle/introduction.md Outdated Show resolved Hide resolved
site/packages/aa-signers/particle/introduction.md Outdated Show resolved Hide resolved
@avasisht23 avasisht23 force-pushed the 12-04-feat_add_particle_to_aa-signers branch from a540b82 to cb6ddd1 Compare December 7, 2023 22:18
@avasisht23 avasisht23 force-pushed the 12-03-feat_add_fireblocks_to_aa-signers branch from f369f33 to 6f369aa Compare December 11, 2023 18:31
@avasisht23 avasisht23 force-pushed the 12-04-feat_add_particle_to_aa-signers branch 2 times, most recently from d6c462d to cc37ab8 Compare December 11, 2023 19:54
moldy530
moldy530 previously approved these changes Dec 11, 2023
Base automatically changed from 12-03-feat_add_fireblocks_to_aa-signers to main December 11, 2023 20:04
@avasisht23 avasisht23 dismissed moldy530’s stale review December 11, 2023 20:04

The base branch was changed.

@avasisht23 avasisht23 force-pushed the 12-04-feat_add_particle_to_aa-signers branch from cc37ab8 to 194682e Compare December 11, 2023 20:05
moldy530
moldy530 previously approved these changes Dec 11, 2023
@avasisht23 avasisht23 merged commit e049c2c into main Dec 11, 2023
4 checks passed
@avasisht23 avasisht23 deleted the 12-04-feat_add_particle_to_aa-signers branch December 11, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants