-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add particle to aa-signers #304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2023
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
7 tasks
avasisht23
force-pushed
the
12-03-feat_add_fireblocks_to_aa-signers
branch
from
December 4, 2023 19:44
dee199a
to
ccdca68
Compare
avasisht23
force-pushed
the
12-04-feat_add_particle_to_aa-signers
branch
from
December 4, 2023 19:44
971f81e
to
87e8329
Compare
avasisht23
force-pushed
the
12-03-feat_add_fireblocks_to_aa-signers
branch
from
December 4, 2023 21:57
ccdca68
to
e55a747
Compare
avasisht23
force-pushed
the
12-04-feat_add_particle_to_aa-signers
branch
from
December 4, 2023 21:57
87e8329
to
8d51d6d
Compare
avasisht23
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
denniswon
as code owners
December 4, 2023 22:00
7 tasks
TABASCOatw
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for putting this together! Took a look and threw in a few comments.
moldy530
approved these changes
Dec 5, 2023
avasisht23
force-pushed
the
12-04-feat_add_particle_to_aa-signers
branch
from
December 7, 2023 22:18
a540b82
to
cb6ddd1
Compare
avasisht23
force-pushed
the
12-03-feat_add_fireblocks_to_aa-signers
branch
from
December 11, 2023 18:31
f369f33
to
6f369aa
Compare
avasisht23
force-pushed
the
12-04-feat_add_particle_to_aa-signers
branch
2 times, most recently
from
December 11, 2023 19:54
d6c462d
to
cc37ab8
Compare
moldy530
previously approved these changes
Dec 11, 2023
Base automatically changed from
12-03-feat_add_fireblocks_to_aa-signers
to
main
December 11, 2023 20:04
avasisht23
force-pushed
the
12-04-feat_add_particle_to_aa-signers
branch
from
December 11, 2023 20:05
cc37ab8
to
194682e
Compare
moldy530
previously approved these changes
Dec 11, 2023
moldy530
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR adds support for Particle authentication and signing methods to the
ParticleSigner
in theaa-signers
package.Detailed summary
ParticleSigner
andParticleAuthenticationParams
topackages/signers/src/particle/index.ts
ParticleUserInfo
interface topackages/signers/src/particle/types.ts
site/.vitepress/config.ts
to include documentation forParticleSigner
methods@particle-network/auth
and@particle-network/provider
as dependencies inpackages/signers/package.json
getAddress
,signMessage
,getAuthDetails
, andsignTypedData
methods insite/packages/aa-signers/particle
site/smart-accounts/signers/guides/particle-network.md
to include setup instructions forParticleSigner
createParticleSigner
function insite/snippets/particle.ts
authenticate
method insite/packages/aa-signers/particle/authenticate.md