-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend msca account with account loupe decorators #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniswon
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
avasisht23
as code owners
December 4, 2023 15:04
denniswon
force-pushed
the
denniswon/msca-accout-loupe
branch
from
December 4, 2023 15:05
2dbf3c1
to
5d1f24e
Compare
moldy530
reviewed
Dec 4, 2023
moldy530
force-pushed
the
denniswon/msca-accout-loupe
branch
from
December 4, 2023 19:36
5d1f24e
to
0684750
Compare
moldy530
force-pushed
the
denniswon/msca-accout-loupe
branch
from
December 4, 2023 20:09
0684750
to
13b61d4
Compare
denniswon
force-pushed
the
denniswon/msca-accout-loupe
branch
from
December 4, 2023 20:26
13b61d4
to
806d493
Compare
moldy530
reviewed
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
take aways from offline convo:
- add
extend
method toISmartContractAccount
with impl inBaseSmartContractAccount
-- should be copy paste impl from Provider since it's the same concept - Update the loupe decorator to just take in the account
- remove
extendWithLoupe
method from builder and dynamic class - call
account.extend(accountLoupeDecorator)
in themulti-owner-account.ts
builder method
denniswon
force-pushed
the
denniswon/msca-accout-loupe
branch
from
December 4, 2023 20:35
806d493
to
b92f564
Compare
denniswon
changed the title
feat: add optional param account loupe address to msca
feat: extend msca account with account loupe decorators
Dec 4, 2023
moldy530
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a view nits but LGTM otherwise
denniswon
force-pushed
the
denniswon/msca-accout-loupe
branch
from
December 5, 2023 22:52
3f647d9
to
5dac618
Compare
moldy530
approved these changes
Dec 5, 2023
Co-authored-by: Michael Moldoveanu <[email protected]>
Co-authored-by: Michael Moldoveanu <[email protected]>
Co-authored-by: Michael Moldoveanu <[email protected]>
Co-authored-by: Michael Moldoveanu <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on improving the code structure and type definitions.
Detailed summary
extend
method to theBaseSmartContractAccount
class.AccountLoupe
feature.IAccountLoupe
interface with new methods.