Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend msca account with account loupe decorators #302

Merged
merged 8 commits into from
Dec 5, 2023

Conversation

denniswon
Copy link
Contributor

@denniswon denniswon commented Dec 4, 2023

Pull Request Checklist


PR-Codex overview

This PR focuses on improving the code structure and type definitions.

Detailed summary

  • Updated imports in multiple files to use the correct file paths.
  • Added a new extend method to the BaseSmartContractAccount class.
  • Added new types and functions related to the AccountLoupe feature.
  • Updated the IAccountLoupe interface with new methods.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

packages/accounts/src/msca/account-loupe/decorator.ts Outdated Show resolved Hide resolved
packages/accounts/src/msca/builder.ts Outdated Show resolved Hide resolved
packages/accounts/src/msca/multi-owner-account.ts Outdated Show resolved Hide resolved
packages/accounts/src/msca/multi-owner-account.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@moldy530 moldy530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take aways from offline convo:

  1. add extend method to ISmartContractAccount with impl in BaseSmartContractAccount -- should be copy paste impl from Provider since it's the same concept
  2. Update the loupe decorator to just take in the account
  3. remove extendWithLoupe method from builder and dynamic class
  4. call account.extend(accountLoupeDecorator) in the multi-owner-account.ts builder method

@denniswon denniswon changed the title feat: add optional param account loupe address to msca feat: extend msca account with account loupe decorators Dec 4, 2023
Copy link
Collaborator

@moldy530 moldy530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a view nits but LGTM otherwise

packages/core/src/account/types.ts Outdated Show resolved Hide resolved
packages/core/src/account/types.ts Outdated Show resolved Hide resolved
packages/core/src/account/types.ts Outdated Show resolved Hide resolved
packages/accounts/src/msca/account-loupe/decorator.ts Outdated Show resolved Hide resolved
@denniswon denniswon merged commit 1e6cf6c into msca-base Dec 5, 2023
2 checks passed
@denniswon denniswon deleted the denniswon/msca-accout-loupe branch December 5, 2023 23:17
@denniswon denniswon restored the denniswon/msca-accout-loupe branch December 6, 2023 23:09
@denniswon denniswon deleted the denniswon/msca-accout-loupe branch December 7, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants