-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge development into main for new major version release #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: abstract out entry point contract address from SCA provider params * feat: make entry point address as an optional param to SCA provider class * feat: update docs for the new utils methods * Update site/packages/aa-core/utils/getDefaultEntryPointContract.md Co-authored-by: Ajay Vasisht <[email protected]> * Update site/packages/aa-core/utils/getDefaultSimpleAccountFactory.md Co-authored-by: Ajay Vasisht <[email protected]> * chore: nit error message update and refactoring --------- Co-authored-by: Ajay Vasisht <[email protected]>
…181) Co-authored-by: Ajay Vasisht <[email protected]>
* docs: update the magic docs to highlight signer creation is async * docs: update the magic docs to highlight signer creation is async
* feat: abstract out entry point contract address from SCA provider params * feat: make entry point address as an optional param to SCA provider class * feat: update docs for the new utils methods * Update site/packages/aa-core/utils/getDefaultEntryPointContract.md Co-authored-by: Ajay Vasisht <[email protected]> * Update site/packages/aa-core/utils/getDefaultSimpleAccountFactory.md Co-authored-by: Ajay Vasisht <[email protected]> * chore: nit error message update and refactoring --------- Co-authored-by: Ajay Vasisht <[email protected]>
…181) Co-authored-by: Ajay Vasisht <[email protected]>
* feat: add zod runtime validation for base account * feat: add zod runtime validation for base account * feat: add zod runtime validation for simple account * refactor: clean up base schemas * refactor: rebase * refactor: rename abitype import
BREAKING CHANGE: forcing breaking change
* feat: abstract out entry point contract address from SCA provider params * feat: make entry point address as an optional param to SCA provider class * feat: update docs for the new utils methods * Update site/packages/aa-core/utils/getDefaultEntryPointContract.md Co-authored-by: Ajay Vasisht <[email protected]> * Update site/packages/aa-core/utils/getDefaultSimpleAccountFactory.md Co-authored-by: Ajay Vasisht <[email protected]> * chore: nit error message update and refactoring --------- Co-authored-by: Ajay Vasisht <[email protected]>
…181) Co-authored-by: Ajay Vasisht <[email protected]>
* docs: update the magic docs to highlight signer creation is async * docs: update the magic docs to highlight signer creation is async
* feat: abstract out entry point contract address from SCA provider params * feat: make entry point address as an optional param to SCA provider class * feat: update docs for the new utils methods * Update site/packages/aa-core/utils/getDefaultEntryPointContract.md Co-authored-by: Ajay Vasisht <[email protected]> * Update site/packages/aa-core/utils/getDefaultSimpleAccountFactory.md Co-authored-by: Ajay Vasisht <[email protected]> * chore: nit error message update and refactoring --------- Co-authored-by: Ajay Vasisht <[email protected]>
…181) Co-authored-by: Ajay Vasisht <[email protected]>
* feat: add zod runtime validation for base account * feat: add zod runtime validation for base account * feat: add zod runtime validation for simple account * refactor: clean up base schemas * refactor: rebase * refactor: rename abitype import
…#290) * docs: update CONTRIBUTING guide, fix PR template, and clean up README * Update CONTRIBUTING.md Co-authored-by: Ajay Vasisht <[email protected]> * Update README.md Co-authored-by: Ajay Vasisht <[email protected]> * docs: make requested changes --------- Co-authored-by: Ajay Vasisht <[email protected]>
…matic fee options for userops (#276) * feat: aa-core smart account provider fee options to handle more systematic fee options for userops * feat: remove fee options middleware and expose fee options to middleware functions * feat: aa-alchemy ergonomic support for handling gas estimation (#243) * feat: support updated overrides for alchemy request gas and paymaster and data * feat: rebase parent where account middle func def is updated * Update site/packages/aa-alchemy/middleware/withAlchemyGasManager.md Co-authored-by: Ajay Vasisht <[email protected]> * Update packages/core/src/utils/index.ts Co-authored-by: Ajay Vasisht <[email protected]> * Update packages/core/src/utils/index.ts Co-authored-by: Ajay Vasisht <[email protected]> * Update packages/core/src/provider/base.ts Co-authored-by: Michael Moldoveanu <[email protected]> * fix: alchemy gas manager 0x check for user op overrides --------- Co-authored-by: Ajay Vasisht <[email protected]> Co-authored-by: Michael Moldoveanu <[email protected]>
* feat: support one-off percentage overrides for user operations * feat: apply user op override or fee option utils in aa-core
…errides (#277) * feat: support one-off percentage overrides for user operations * feat: apply user op override or fee option utils in aa-core * docs: add documentation for smart account provider fee options and overrides * docs: add glossary section and add general types doc in the section
avasisht23
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
denniswon
as code owners
December 1, 2023 17:26
moldy530
previously approved these changes
Dec 1, 2023
closing in favor of #295 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:fix
)development
and notmain
?PR-Codex overview
Focus of this PR:
Update dependencies and configuration files for the
signers
andalchemy
packages.Detailed summary:
tsconfig.json
andtsconfig.build.json
files in thesigners
package.magic
andweb3auth
modules of thesigners
package.signers
package.package.json
file in theaccounts
package.getOwnerAddress.md
andsignTypedData.md
files in theaa-accounts
package.web3auth
module of thesigners
package.constants.ts
file in thealchemy
package.alchemy
package.Footer.tsx
file in theaa-simple-dapp
example.alchemy
package.signers
package.package.json
file in theaa-simple-dapp
example.signers
package.account.ts
file in theaccounts
package.index.ts
file in thealchemy
package.vitest.config.ts
andvitest.config.e2e.ts
files in thesigners
package.package.json
file in thealchemy-daapp
example.simulate-uo.ts
file in thealchemy
package.magic
module of thesigners
package.package.json
file in theaa-core
package.account-alchemy.ts
file in the snippets.deployment-addresses.md
file in the snippets.sendUserOperation.md
file in theaa-core
package.light-account-provider.ts
file in the snippets.package.json
file in thealchemy
package.signMessageWith6492.md
file in the snippets.getDummySignature.md
file in theaa-core
package.signTypedDataWith6492.md
file in the snippets.