feat: support one-off percentage overrides for user operations #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniswon
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
avasisht23
as code owners
moldy530
reviewed
Nov 28, 2023
avasisht23
reviewed
Nov 28, 2023
denniswon
force-pushed
the
denniswon/feeoptions
branch
4 times, most recently
from
9048fcb
to
f06f1c5
Compare
denniswon
force-pushed
the
denniswon/userop-overrides-percentage
branch
3 times, most recently
from
5dd80e2
to
05b78a3
Compare
denniswon
force-pushed
the
denniswon/feeoptions
branch
from
f108d0a
to
4f5d49f
Compare
denniswon
force-pushed
the
denniswon/userop-overrides-percentage
branch
from
05b78a3
to
21aa58e
Compare
moldy530
approved these changes
Nov 30, 2023
avasisht23
reviewed
Nov 30, 2023
packages/core/src/provider/base.ts
Outdated
Comment on lines
532
to
535
| applyUserOperationOverride( | ||
| estimates.callGasLimit, | ||
| overrides?.callGasLimit | ||
| ) || applyFeeOption(estimates.callGasLimit, feeOptions?.callGasLimit); |
There was a problem hiding this comment.
can you wrap this in a util? seems repeated below but generalizable on input
|
@avasisht23 accommodated your comment. thank you! |
moldy530
pushed a commit
that referenced
this pull request
Dec 1, 2023
* feat: support one-off percentage overrides for user operations * feat: apply user op override or fee option utils in aa-core
moldy530
pushed a commit
that referenced
this pull request
Dec 1, 2023
* feat: support one-off percentage overrides for user operations * feat: apply user op override or fee option utils in aa-core
avasisht23
pushed a commit
that referenced
this pull request
Dec 3, 2023
* feat: support one-off percentage overrides for user operations * feat: apply user op override or fee option utils in aa-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on improving the fee options and overrides functionality in the code.
Detailed summary:
applyFeeOptiontoapplyUserOpFeeOptionand added new functionsapplyUserOpOverrideandapplyUserOpOverrideOrFeeOption.UserOperationOverridestype to include new fields for overrides and fee options.withFeeDataGettermethod in the provider to handle the new overrides and fee options.