feat: add upgrade functionality for light account to msca #285

avasisht23 · 2023-11-28T05:06:45Z

Pull Request Checklist

Did you add new tests and confirm existing tests pass? (yarn test)
Did you update relevant docs? (docs are found in the site folder, see guidleines below)
Do your commits follow the Conventional Commits standard?
Does your PR title also follow the Conventional Commits standard?
If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples? (e.g. feat!: breaking change)
Did you run lint (yarn lint:check) and fix any issues? (yarn lint:fix)
Is the base branch you're merging into development and not main?

PR-Codex overview

Focus of this PR:

This PR focuses on upgrading the Light Account implementation to a Modular Account implementation using the MultiOwnerPlugin.

Detailed summary:

Upgraded the LightSmartContractAccount implementation to a Modular Account implementation.
Added the ability to upgrade a deployed Light Account to a Modular Account using the MultiOwnerPlugin.
Added tests for upgrading deployed and undeployed Light Accounts to Modular Accounts.

The following files were skipped due to too many changes: packages/accounts/src/msca/abis/UpgradeableModularAccount.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

avasisht23 · 2023-11-28T05:06:57Z

main
- feat: add initial skeleton for 6900 account support #248
  - feat: add upgrade functionality for light account to msca #298
  - feat: add upgrade functionality for light account to msca #285 👈

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @avasisht23 and the rest of your teammates on Graphite

packages/accounts/src/light-account/account.ts

avasisht23 · 2023-12-01T01:11:43Z

packages/accounts/src/light-account/account.ts

+        createMultiOwnerMSCA({
+          rpcClient,
+          factoryAddress: getDefaultMSCAFactoryAddress(provider.chain),
+          owner,
+          index: 0n,
+          chain: provider.chain,
+          accountAddress,
+        })


This is why making the upgrade function generic is difficult. the return type depends on the account type introduced to create a "connected" provider via .connect.

We ran into the same issue with the createLightAccountAlchemyProvider factory PR.

Any ideas on how to genericize without running into this error, which can only be resolved with an unknown cast:

avasisht23 · 2023-12-01T01:26:13Z

packages/accounts/src/light-account/account.ts

+  static readonly implementationAddress =
+    "0x5467b1947f47d0646704eb801e075e72aeae8113";
+  static readonly storageSlot =
+    "0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc";


might want to consider a subclass of Base/Simple like Upgradeable that has these fields

)

…#290) * docs: update CONTRIBUTING guide, fix PR template, and clean up README * Update CONTRIBUTING.md Co-authored-by: Ajay Vasisht <[email protected]> * Update README.md Co-authored-by: Ajay Vasisht <[email protected]> * docs: make requested changes --------- Co-authored-by: Ajay Vasisht <[email protected]>

…matic fee options for userops (#276) * feat: aa-core smart account provider fee options to handle more systematic fee options for userops * feat: remove fee options middleware and expose fee options to middleware functions * feat: aa-alchemy ergonomic support for handling gas estimation (#243) * feat: support updated overrides for alchemy request gas and paymaster and data * feat: rebase parent where account middle func def is updated * Update site/packages/aa-alchemy/middleware/withAlchemyGasManager.md Co-authored-by: Ajay Vasisht <[email protected]> * Update packages/core/src/utils/index.ts Co-authored-by: Ajay Vasisht <[email protected]> * Update packages/core/src/utils/index.ts Co-authored-by: Ajay Vasisht <[email protected]> * Update packages/core/src/provider/base.ts Co-authored-by: Michael Moldoveanu <[email protected]> * fix: alchemy gas manager 0x check for user op overrides --------- Co-authored-by: Ajay Vasisht <[email protected]> Co-authored-by: Michael Moldoveanu <[email protected]>

* feat: support one-off percentage overrides for user operations * feat: apply user op override or fee option utils in aa-core

…errides (#277) * feat: support one-off percentage overrides for user operations * feat: apply user op override or fee option utils in aa-core * docs: add documentation for smart account provider fee options and overrides * docs: add glossary section and add general types doc in the section

* feat: add some plugin generation logic * chore: add generate commands * style: apply PR suggestion Co-authored-by: Dennis Won <[email protected]> * refactor: create plugin config concept * feat: add multi-owner-msca impl that leverages the plugin gen (#263) * feat: add multi-owner-msca impl that leverages the plugin gen * feat: proposal for msca builder pattern (#264) * feat: proposal for msca builder pattern * refactor: rework plugin gen to create read methods for the account --------- Co-authored-by: Dennis Won <[email protected]>

* feat: add initial skeleton for 6900 account support * feat: add some plugin generation logic (#262) * feat: add some plugin generation logic * chore: add generate commands * style: apply PR suggestion Co-authored-by: Dennis Won <[email protected]> * refactor: create plugin config concept * feat: add multi-owner-msca impl that leverages the plugin gen (#263) * feat: add multi-owner-msca impl that leverages the plugin gen * feat: proposal for msca builder pattern (#264) * feat: proposal for msca builder pattern * refactor: rework plugin gen to create read methods for the account --------- Co-authored-by: Dennis Won <[email protected]> * chore: update plugin gen * feat: add plugin manager decorator for MSCA * feat: add a mechanism for adding provider decorators to accounts (#287) * feat: add a mechanism for adding provider decorators to accounts * chore: update lerna and package json to lint generated files * refactor: rename MSCA to IMSCA --------- Co-authored-by: Dennis Won <[email protected]> Co-authored-by: avasisht23 <[email protected]>

avasisht23 mentioned this pull request Nov 28, 2023

feat: add initial skeleton for 6900 account support #248

Merged

7 tasks

avasisht23 force-pushed the 11-28-feat_add_upgrade_functionality_for_light_account_to_msca branch from 8cb511a to 109c2c1 Compare November 28, 2023 05:26

moldy530 reviewed Nov 28, 2023

View reviewed changes

packages/accounts/src/light-account/account.ts Show resolved Hide resolved

moldy530 reviewed Nov 28, 2023

View reviewed changes

packages/accounts/src/light-account/account.ts Outdated Show resolved Hide resolved

avasisht23 force-pushed the msca-base branch from 2b924c0 to e453d12 Compare November 29, 2023 18:17

avasisht23 force-pushed the 11-28-feat_add_upgrade_functionality_for_light_account_to_msca branch from bd93c3c to 7373bcc Compare November 29, 2023 18:18

avasisht23 force-pushed the msca-base branch from e453d12 to 26460de Compare November 29, 2023 18:23

avasisht23 force-pushed the 11-28-feat_add_upgrade_functionality_for_light_account_to_msca branch from 7373bcc to a3ed2b9 Compare November 29, 2023 18:23

avasisht23 commented Dec 1, 2023

View reviewed changes

avasisht23 force-pushed the msca-base branch from 26460de to ba7f7c4 Compare December 1, 2023 01:23

avasisht23 force-pushed the 11-28-feat_add_upgrade_functionality_for_light_account_to_msca branch from 235df73 to 4873496 Compare December 1, 2023 01:23

avasisht23 commented Dec 1, 2023

View reviewed changes

avasisht23 force-pushed the msca-base branch from ba7f7c4 to e45e903 Compare December 1, 2023 08:54

avasisht23 force-pushed the 11-28-feat_add_upgrade_functionality_for_light_account_to_msca branch 2 times, most recently from e4afc83 to af52780 Compare December 1, 2023 17:20

moldy530 and others added 14 commits December 1, 2023 12:39

feat: allow passing raw call data to sendUserOperation (#272)

26b90b6

fix: preserve the connected account when using alchemy middlewares (#273

94f5dee

)

feat: add aa-signers package (#228)

5fcd322

chore: fix typescript export type for LogLevel in aa-core (#275)

e69da8e

Small edits to particle-network.md (#278)

2caf3fc

docs: fix link to contribute a signer (#279)

66abca6

feat: add magic signer to aa-signers (#229)

860d177

feat: add web3auth signer to aa-signers (#247)

7d0492b

docs: change UserOperation to UO where needed (#288)

e4510f1

docs: make edits to follow style guidelines (#257)

d82d86b

feat: support one-off percentage overrides for user operations (#289)

dc979ff

* feat: support one-off percentage overrides for user operations * feat: apply user op override or fee option utils in aa-core

denniswon and others added 7 commits December 1, 2023 12:39

docs: update alchemy provider constructor doc with updated config (#293)

0f5639a

chore: change back to using development branch

0d6bf9b

feat: add initial skeleton for 6900 account support

9ddf255

chore: lint

c2a357a

fix: missed some plugingen fixes

7b96662

moldy530 force-pushed the msca-base branch from 85c008e to 7b96662 Compare December 1, 2023 17:44

avasisht23 added 16 commits December 1, 2023 12:50

feat: add upgrade functionality for light account to msca

7ca497b

feat: add upgrade functionality for light account to msca

27f6734

feat: add upgrade functionality for light account to msca

1131f0d

feat: add upgrade functionality for light account to msca

9f9c4ec

feat: add upgrade functionality for light account to msca

1265825

feat: update call

722581e

feat: update manifest call

04b5b2d

feat: update manifest call

0a0a007

feat: parseAbiParams added

655696e

feat: wrap calldata again

d2f6952

feat: wrap calldata again

1a708bb

feat: fix accountAddress

1c2a8d1

test: test for undeployed accounts

0201662

feat: generalize the upgrade implementation as much as possible

4a947bf

feat: generalize the upgrade implementation as much as possible

0b6ec8b

chore: rebase

d22845c

moldy530 force-pushed the 11-28-feat_add_upgrade_functionality_for_light_account_to_msca branch from af52780 to d22845c Compare December 1, 2023 17:50

denniswon force-pushed the msca-base branch from 7b96662 to 9199774 Compare December 1, 2023 21:31

avasisht23 force-pushed the msca-base branch from 6142f07 to c69950e Compare December 3, 2023 01:36

avasisht23 mentioned this pull request Dec 3, 2023

feat: add upgrade functionality for light account to msca #298

Merged

8 tasks

avasisht23 closed this Dec 3, 2023

moldy530 deleted the 11-28-feat_add_upgrade_functionality_for_light_account_to_msca branch January 30, 2024 22:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add upgrade functionality for light account to msca #285

feat: add upgrade functionality for light account to msca #285

avasisht23 commented Nov 28, 2023 •

edited by pr-codex bot

Loading

avasisht23 commented Nov 28, 2023 •

edited

Loading

avasisht23 Dec 1, 2023

avasisht23 Dec 1, 2023

feat: add upgrade functionality for light account to msca #285

feat: add upgrade functionality for light account to msca #285

Conversation

avasisht23 commented Nov 28, 2023 • edited by pr-codex bot Loading

Pull Request Checklist

PR-Codex overview

Focus of this PR:

Detailed summary:

avasisht23 commented Nov 28, 2023 • edited Loading

avasisht23 Dec 1, 2023

Choose a reason for hiding this comment

avasisht23 Dec 1, 2023

Choose a reason for hiding this comment

avasisht23 commented Nov 28, 2023 •

edited by pr-codex bot

Loading

avasisht23 commented Nov 28, 2023 •

edited

Loading