-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a convenience method to make creating an alchemy provider easier #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moldy530
requested review from
rthomare,
dancoombs,
mokok123,
avasisht23 and
denniswon
as code owners
November 2, 2023 15:11
avasisht23
force-pushed
the
moldy/alch-provider-cleanup
branch
from
November 3, 2023 18:48
329982a
to
d35682f
Compare
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
avasisht23
force-pushed
the
moldy/alch-provider-cleanup
branch
2 times, most recently
from
November 3, 2023 21:34
0927b1b
to
daed7b0
Compare
avasisht23
force-pushed
the
development
branch
from
November 3, 2023 21:36
9d7a15f
to
a886853
Compare
avasisht23
force-pushed
the
moldy/alch-provider-cleanup
branch
2 times, most recently
from
November 9, 2023 22:31
634b249
to
e6e7b8d
Compare
avasisht23
force-pushed
the
moldy/alch-provider-cleanup
branch
from
November 10, 2023 05:23
38f5290
to
7e3eeae
Compare
avasisht23
changed the base branch from
development
to
11-12-test_adjust_e2e_tests
November 12, 2023 20:08
avasisht23
force-pushed
the
moldy/alch-provider-cleanup
branch
from
November 12, 2023 20:08
06a8d2f
to
f548d76
Compare
7 tasks
avasisht23
force-pushed
the
moldy/alch-provider-cleanup
branch
3 times, most recently
from
November 12, 2023 21:18
a14a362
to
53c3f0e
Compare
avasisht23
reviewed
Nov 12, 2023
avasisht23
force-pushed
the
moldy/alch-provider-cleanup
branch
from
November 12, 2023 21:48
53c3f0e
to
9d80133
Compare
7 tasks
avasisht23
force-pushed
the
11-12-test_adjust_e2e_tests
branch
from
November 14, 2023 19:46
7ecae28
to
30afd81
Compare
avasisht23
force-pushed
the
moldy/alch-provider-cleanup
branch
from
November 14, 2023 19:46
9d80133
to
2a3619f
Compare
avasisht23
force-pushed
the
11-12-test_adjust_e2e_tests
branch
from
November 14, 2023 20:50
30afd81
to
9b9be45
Compare
avasisht23
force-pushed
the
moldy/alch-provider-cleanup
branch
from
November 14, 2023 20:50
2a3619f
to
d4b5241
Compare
avasisht23
force-pushed
the
11-12-test_adjust_e2e_tests
branch
from
November 14, 2023 22:43
9b9be45
to
381d029
Compare
avasisht23
force-pushed
the
moldy/alch-provider-cleanup
branch
from
November 14, 2023 22:43
d4b5241
to
0405c49
Compare
avasisht23
force-pushed
the
moldy/alch-provider-cleanup
branch
3 times, most recently
from
November 27, 2023 22:29
1668c91
to
f4c26b9
Compare
denniswon
reviewed
Nov 28, 2023
packages/accounts/src/light-account/e2e-tests/light-account.test.ts
Outdated
Show resolved
Hide resolved
avasisht23
force-pushed
the
moldy/alch-provider-cleanup
branch
from
November 28, 2023 20:13
f4c26b9
to
9068685
Compare
denniswon
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase then lgtm. Thanks!
avasisht23
force-pushed
the
moldy/alch-provider-cleanup
branch
from
December 1, 2023 04:47
9068685
to
d50cc1c
Compare
moldy530
added a commit
that referenced
this pull request
Dec 1, 2023
moldy530
added a commit
that referenced
this pull request
Dec 1, 2023
avasisht23
pushed a commit
that referenced
this pull request
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, see guidleines below)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:fix
)development
and notmain
?PR-Codex overview
This PR focuses on introducing a new
LightAccountProvider
andLightAccountAlchemyProvider
to the codebase. The notable changes include:createLightAccountProvider
andcreateLightAccountAlchemyProvider
functions.LightAccountProviderConfigSchema
andLightAccountAlchemyProviderConfigSchema
schemas.