Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a convenience method to make creating an alchemy provider easier #206

Merged
merged 17 commits into from
Dec 1, 2023

Conversation

moldy530
Copy link
Collaborator

@moldy530 moldy530 commented Nov 2, 2023

Pull Request Checklist

  • Did you add new tests and confirm existing tests pass? (yarn test)
  • Did you update relevant docs? (docs are found in the site folder, see guidleines below)
  • Do your commits follow the Conventional Commits standard?
  • Does your PR title also follow the Conventional Commits standard?
  • If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples? (e.g. feat!: breaking change)
  • Did you run lint (yarn lint:check) and fix any issues? (yarn lint:fix)
  • Is the base branch you're merging into development and not main?

PR-Codex overview

This PR focuses on introducing a new LightAccountProvider and LightAccountAlchemyProvider to the codebase. The notable changes include:

  • Adding createLightAccountProvider and createLightAccountAlchemyProvider functions.
  • Adding LightAccountProviderConfigSchema and LightAccountAlchemyProviderConfigSchema schemas.
  • Updating various import statements to use the new provider.
  • Adding tests and documentation related to the new provider.

The following files were skipped due to too many changes: packages/alchemy/src/provider/light-account.ts, packages/alchemy/src/__tests__/provider.test.ts, site/smart-accounts/accounts/modular-account.md, packages/accounts/src/light-account/e2e-tests/light-account.test.ts, packages/alchemy/src/provider.ts, packages/alchemy/e2e-tests/simple-account.test.ts, site/packages/aa-accounts/light-account/provider.md, site/packages/aa-alchemy/provider/light-account-factory.md

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@avasisht23
Copy link
Contributor

avasisht23 commented Nov 3, 2023

@avasisht23 avasisht23 force-pushed the moldy/alch-provider-cleanup branch 2 times, most recently from 0927b1b to daed7b0 Compare November 3, 2023 21:34
@avasisht23 avasisht23 force-pushed the moldy/alch-provider-cleanup branch 2 times, most recently from 634b249 to e6e7b8d Compare November 9, 2023 22:31
@alchemyplatform alchemyplatform deleted a comment from moldy530 Nov 9, 2023
@avasisht23 avasisht23 changed the base branch from development to 11-12-test_adjust_e2e_tests November 12, 2023 20:08
@avasisht23 avasisht23 force-pushed the moldy/alch-provider-cleanup branch 3 times, most recently from a14a362 to 53c3f0e Compare November 12, 2023 21:18
Base automatically changed from 11-12-test_adjust_e2e_tests to development November 14, 2023 23:18
@avasisht23 avasisht23 force-pushed the moldy/alch-provider-cleanup branch 3 times, most recently from 1668c91 to f4c26b9 Compare November 27, 2023 22:29
Copy link
Contributor

@denniswon denniswon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase then lgtm. Thanks!

@avasisht23 avasisht23 merged commit 0fb8911 into development Dec 1, 2023
3 checks passed
@avasisht23 avasisht23 deleted the moldy/alch-provider-cleanup branch December 1, 2023 08:41
@moldy530 moldy530 mentioned this pull request Dec 1, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants