CI improvements

albin-johansson · Oct 16, 2023 · c160634 · c160634
1 parent 66b54d4
commit c160634
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
@@ -4,7 +4,7 @@ on: [ push ]
 
 env:
   VCPKG_ROOT: ${{github.workspace}}/vcpkg
-  VCPKG_TARGET_TRIPLET: arm64-osx-dynamic
+  VCPKG_TARGET_TRIPLET: x64-osx-dynamic
   VCPKG_DEFAULT_BINARY_CACHE: ${{github.workspace}}/vcpkg/bincache
   VCPKG_CACHE_EDITION: 1
 
@@ -61,5 +61,5 @@ jobs:
         run: ninja -C build
 
       - name: Run core tests
-        working-directory: ./build/debug/test
+        working-directory: ./build/debug
         run: ./tactile-core-test
diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml
@@ -77,5 +77,5 @@ jobs:
         run: ninja -C build
 
       - name: Run core tests
-        working-directory: ./build/debug/test
+        working-directory: ./build/debug
         run: ./tactile-core-test
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -57,6 +57,5 @@ jobs:
         run: ninja -C build
 
       - name: Run core tests
-        working-directory: ./build/debug/test
-        shell: cmd
+        working-directory: ./build/debug
         run: tactile-core-test.exe
diff --git a/modules/core/inc/tactile/core/io/compression/compression_error.hpp b/modules/core/inc/tactile/core/io/compression/compression_error.hpp
@@ -22,7 +22,8 @@ class CompressionErrorDomain final : public IErrorDomain {
 
   constexpr CompressionErrorDomain() noexcept = default;
 
-  constexpr ~CompressionErrorDomain() noexcept override = default;
+  constexpr ~CompressionErrorDomain() noexcept override  // NOLINT: GCC workaround
+  {}
 
   TACTILE_DEFAULT_COPY(CompressionErrorDomain);
   TACTILE_DEFAULT_MOVE(CompressionErrorDomain);

diff --git a/modules/core/inc/tactile/core/io/save/save_format_error.hpp b/modules/core/inc/tactile/core/io/save/save_format_error.hpp
@@ -31,7 +31,8 @@ class SaveFormatErrorDomain final : public IErrorDomain {
 
   constexpr SaveFormatErrorDomain() noexcept = default;
 
-  constexpr ~SaveFormatErrorDomain() noexcept override = default;
+  constexpr ~SaveFormatErrorDomain() noexcept override  // NOLINT: GCC workaround
+  {}
 
   TACTILE_DEFAULT_COPY(SaveFormatErrorDomain);
   TACTILE_DEFAULT_MOVE(SaveFormatErrorDomain);