Skip to content

Commit

Permalink
Tweak DLL visibility stuff
Browse files Browse the repository at this point in the history
  • Loading branch information
albin-johansson committed Oct 14, 2023
1 parent 849626b commit 4fc8475
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
1 change: 1 addition & 0 deletions modules/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
)
else ()
set(TACTILE_COMPILE_OPTIONS
-fvisibility=hidden
-Wall
-Wextra
-Wpedantic
Expand Down
4 changes: 2 additions & 2 deletions modules/core/inc/tactile/core/prelude.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@
#define TACTILE_DLL_EXPORT __attribute__((__visibility__("default")))
#define TACTILE_DLL_IMPORT
#elif TACTILE_COMPILER_GCC
#define TACTILE_DLL_EXPORT __attribute__((dllexport))
#define TACTILE_DLL_IMPORT __attribute__((dllimport))
#define TACTILE_DLL_EXPORT __attribute__((visibility("default")))
#define TACTILE_DLL_IMPORT
#else
#define TACTILE_DLL_EXPORT
#define TACTILE_DLL_IMPORT
Expand Down
6 changes: 3 additions & 3 deletions modules/editor/inc/tactile/editor/cmd/command_stack.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -170,18 +170,18 @@ class CommandStack final {
void _store(Unique<ICommand> cmd);

/** \brief Removes the oldest command from the stack, i.e., the one at the bottom. */
void _remove_oldest_command();
TACTILE_EDITOR_API void _remove_oldest_command();

/** \brief Removes all commands to the right of the current index (newer ones). */
void _remove_commands_after_current_index();
TACTILE_EDITOR_API void _remove_commands_after_current_index();

void _reset_or_decrease_clean_index();

/** \brief Shifts the current index to the left (to an older command). */
void _reset_or_decrease_current_index();

/** \brief Shifts the current index to the right (to a newer command). */
void _increase_current_index();
TACTILE_EDITOR_API void _increase_current_index();

[[nodiscard]] auto _get_next_command_index() const -> usize;
};
Expand Down
5 changes: 2 additions & 3 deletions modules/editor/src/tactile/editor/cmd/command_stack.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@
namespace tactile {

CommandStack::CommandStack(const usize capacity)
: mCapacity {capacity}
{
}
: mCapacity {capacity}
{}

void CommandStack::clear()
{
Expand Down

0 comments on commit 4fc8475

Please sign in to comment.