feat(ui): add resolution-aware scaling to main menu layout #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented dynamic scaling logic in MainMenu::render() to make the main menu UI adapt to various screen resolutions. Scaling factors are now calculated based on a 1024x768 baseline, with optional caps for layout and font scaling. This improves usability at 1080p, 1440p, and 4K without breaking existing layout behavior.
- Manually center and scale copyright text based on resolution - Prevent duplicate rendering by disabling default GUI window draw - Ensures proper alignment at all resolutions, including 4K
alariq
reviewed
Apr 8, 2025
| @@ -770,8 +776,13 @@ void MainMenu::render() | |||
| } | |||
| } | |||
|
|
|||
| GUI_RECT rect = { 0, 0, Environment.screenWidth, Environment.screenHeight }; | |||
| drawRect( rect, color ); | |||
| GUI_RECT rect = { | |||
There was a problem hiding this comment.
there is no need to modify it:
1024 * scaleX = 1024 * (Environment.screenWidth / 1024.0f) = Environment.screenWidth
(same for height)
alariq
reviewed
Apr 8, 2025
| @@ -26,6 +26,7 @@ struct DDSURFACEDESC2 { | |||
| #include"gamesound.h" | |||
| #include"aanimobject.h" | |||
| #include"multplyr.h" | |||
| #include <algorithm> | |||
There was a problem hiding this comment.
let's not add dependency for something which can just be a one ternary operator
alariq
reviewed
Apr 8, 2025
| @@ -716,6 +717,11 @@ void MainMenu::update() | |||
| void MainMenu::render() | |||
| { | |||
|
|
|||
| // Calculate scale factors relative to 1024x768 base resolution | |||
| float scaleX = Environment.screenWidth / 1024.0f; | |||
There was a problem hiding this comment.
this can be moved closer to drawShadowText
|
Thank you for your feedback! I'm not an experienced coder and I'm trying to help out however I can. I'll apply your suggestions and reupload! |
Alexbeav
commented
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented dynamic scaling logic in MainMenu::render() to make the main menu UI adapt to various screen resolutions. Scaling factors are now calculated based on a 1024x768 baseline, with optional caps for layout and font scaling. This improves usability at 1080p, 1440p, and 4K without breaking existing layout behavior.