fix: only destruct elements no longer in use when erasing #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tearfur
force-pushed
the
vector-erase
branch
5 times, most recently
from
7d0612a
to
b8fb5a4
Compare
tearfur
changed the title
tearfur
changed the title
|
I had a look already. Looks great. Is it good to go? |
|
Yes, please go ahead. |
|
Done. Thanks for the work you've been doing in the library. We'll create another release once all the stuff you want is merged. |
|
I don't have anything more to contribute at the moment, so feel free to go with your plans! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42.
Related #23.