Skip to content

Pipenv and pip version can be set through env var #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

poulainv
Copy link
Member

@poulainv poulainv commented Feb 2, 2021

Add the ability to override PIP_VERSION & PIPENV_VERSION
I deployed a review app using it (and successfully added ddtrace) — there

how

  • PIPENV_VERSION can not be used as env var see there
  • Heroku configuration variables are available in files see there

Copy link

@ElPicador ElPicador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Thanks for trying this!

Copy link

@Thomas-Mollard Thomas-Mollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking care of this!

@poulainv poulainv merged commit 8e0a38a into alan-eu:main Feb 3, 2021
@timmygee
Copy link

This fix saved my hide. By default it uses a much newer version of pip which means modules like cryptography actually build. I didn't even need to change the pipenv version but it's great to have that there as an option. Heroku really needs to support modern python better. The current buildpack version of pip (9.0.2) just does not cut it anymore.

@edmorley please merge upstream!

@poulainv
Copy link
Member Author

Thanks @timmygee, it became required on our side as well. A few other PR have been already submitted, never merged. See @edmorley's comment about it.

@edmorley
Copy link

Hi! The pipenv version has just been updated in heroku#1169. Sorry for the delay! There's some more context in:
heroku#987 (comment)

Re allowing the pipenv/pip versions to be configured via environment variables, this is something I wouldn't recommend - I've added some additional notes on this to:
heroku#1094 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants