Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter hours to specific range (i.e. opening hours) #341

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

khacpv
Copy link

@khacpv khacpv commented Jun 20, 2016

it's relates to this issues: Filter hours to specific range (i.e. opening hours)
Add limit times to display with a start & end time.

@adamvarhegyi
Copy link

I think it breaks the onEmptyViewClicked(Calendar time) callback. It returns wrong hour with your code.

@smedic
Copy link

smedic commented Jul 3, 2016

Yes, @adamvarhegyi is right.
Just add mStartTime to the line 776.
day.set(Calendar.HOUR, hour + mStartTime);

@khacpv
Copy link
Author

khacpv commented Jul 4, 2016

Thank you for your comments @adamvarhegyi @smedic

The change includes:

  • fix onEmptyViewClicked() as @smedic
  • fix Draw the line at the current time (with mStartTime)

@wwahmed
Copy link

wwahmed commented Aug 17, 2016

Are we planning on merging this feature -- is there anything any of us can do to help?

@entropitor
Copy link
Contributor

@wwahmed See #137. @jhoobergs and I are probably gonna fork this repo under the Quivr organization soon. Then we'll look at all the open Pull Requests.

@khacpv
Copy link
Author

khacpv commented Oct 6, 2016

@caske33 updated on zooming issues changes:

  • add an extra spacing at bottom limit #line 809
  • dont draw title & time lines if out of limit range #line 540 & #line 690
  • change some Calendar.HOUR -> Calendar.HOUR_OF_DAY

@entropitor
Copy link
Contributor

@jhoobergs Can you take a look at this for the Quivr fork, where we have merged this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants