fix: allow existing namespaces to be used #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some use cases where we'd want to use an existing namespace. Without this patch, we can get a client-side conflict. If the namespace already exists, just add the label metadata to the namespace and don't touch anything else. For any other resource we should keep the existing behavior. Signed-off-by: Blake Pettersson <[email protected]>
Lock128
reviewed
Aug 21, 2024
| } | ||
|
|
||
| // Object already exists, just patch the namespace metadata. | ||
| metadata := applyObject.unstructuredObj["metadata"] |
There was a problem hiding this comment.
Should we add a logger.info for this case to be able to identify this in "normal" logs?
Lock128
approved these changes
Aug 21, 2024
Signed-off-by: Blake Pettersson <[email protected]>
jiachengxu
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
There are some use cases where we'd want to use an existing namespace. Without this patch, we can get a client-side conflict. If the namespace already exists, just add the label metadata to the namespace and don't touch anything else. For any other resource we should keep the existing behavior.
How has this code been tested
With a cluster that has a pre-existing namespace.