Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split yaml by matching (?m)^---\n regex #305

Closed
wants to merge 3 commits into from

Conversation

joaoestrela
Copy link
Contributor

Fix issues described on #278 and #294

@joaoestrela joaoestrela requested a review from a team as a code owner August 12, 2024 20:37
Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for docs-kargo-render-akuity-io canceled.

Name Link
🔨 Latest commit 28c9c8f
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-render-akuity-io/deploys/66d5e9af6aa7a60008888af6

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.66%. Comparing base (08b806c) to head (28c9c8f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   29.58%   29.66%   +0.08%     
==========================================
  Files          23       23              
  Lines        1724     1726       +2     
==========================================
+ Hits          510      512       +2     
  Misses       1137     1137              
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour self-assigned this Aug 31, 2024
@hiddeco
Copy link
Contributor

hiddeco commented Sep 30, 2024

While reviewing this, I wondered why we were not making use of a YAML reader that knows how to properly split documents, which resulted in #315. Nonetheless, I want to thank you for your contribution @joaoestrela. 🙇

@hiddeco hiddeco closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants