remove unnecessary push when rendering to local path #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent Rancourt <[email protected]>
✅ Deploy Preview for docs-kargo-render-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
krancour
commented
Mar 27, 2024
Comment on lines
+113
to
+119
| if localTargetBranchExists { | ||
| logger.Debug("target branch exists locally") | ||
| if err = rc.repo.Checkout(rc.request.TargetBranch); err != nil { | ||
| return fmt.Errorf("error checking out target branch: %w", err) | ||
| } | ||
| logger.Debug("checked out target branch") | ||
| } else { |
There was a problem hiding this comment.
Added for good measure; instead of blindly creating an orphan branch.
krancour
commented
Mar 27, 2024
Comment on lines
+127
to
+129
| if rc.request.LocalOutPath != "" { | ||
| return nil // There's no need to push the new branch to the remote | ||
| } |
There was a problem hiding this comment.
This is the important bit.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 27.72% 27.75% +0.03%
==========================================
Files 22 22
Lines 2103 2133 +30
==========================================
+ Hits 583 592 +9
- Misses 1441 1461 +20
- Partials 79 80 +1 ☔ View full report in Codecov by Sentry. |
hiddeco
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.