Feature/node management endpoint #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add new api keys to in-memory properties * persist in-memory properties
* add and persist additional api keys * validate api keys pre-add
…l ones - linked ApiKeyManagementEndpoint with ApiKeyPropertiesAuthProvider - added getProperties() to PropertyFileAPIKeys
…s and added apiKey status consideration
…a bit and reordered methods
…i keys, added junit test for inactive api key in TestPropertyFileApiKeys
…te of api keys, added junit test for inactive api key in TestPropertyFileApiKeys" This reverts commit cbed9c0.
…tEndpoint" This reverts commit 5da3027.
…ndpoint a bit and reordered methods" This reverts commit 43a5381.
This reverts commit 11fb942.
…lacklist INACTIVE state (instead of whitelisting ACTIVE state), removed helper methods from ApiKeyStatus
…on to new requirements (clientDn is not updatable, only INACTIVE state is appended to clientDn)
…emoved messages from responses
rwm
requested changes
Jul 10, 2024
broker-auth-local/src/main/java/org/aktin/broker/auth/apikey/ApiKeyManagementEndpoint.java
Outdated
Show resolved
Hide resolved
broker-auth-local/src/main/java/org/aktin/broker/auth/apikey/ApiKeyManagementEndpoint.java
Outdated
Show resolved
Hide resolved
broker-auth-local/src/main/java/org/aktin/broker/auth/apikey/ApiKeyManagementEndpoint.java
Outdated
Show resolved
Hide resolved
broker-auth-local/src/main/java/org/aktin/broker/auth/apikey/ApiKeyDTO.java
Outdated
Show resolved
Hide resolved
broker-auth-local/src/main/java/org/aktin/broker/auth/apikey/ApiKeyPropertiesAuthProvider.java
Outdated
Show resolved
Hide resolved
broker-auth-local/src/main/java/org/aktin/broker/auth/apikey/ApiKeyPropertiesAuthProvider.java
Outdated
Show resolved
Hide resolved
broker-auth-local/src/main/java/org/aktin/broker/auth/apikey/ApiKeyPropertiesAuthProvider.java
Outdated
Show resolved
Hide resolved
- renamed XmlRootElement name of ApiKeyDTO - renamed postApiKey() to createApiKey() - added exceptions to throw clause - rewrote conditional operator to if-else-statement
rwm
approved these changes
Oct 1, 2024
rwm
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of API key authentication feature in broker-auth-local. Includes: