forked from concourse/github-release-resource
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow filtering versions below a specified version
[Fixes concourse#67]
- Loading branch information
Akshay Mankar
committed
Feb 8, 2018
1 parent
351c6d0
commit 5b53b0b
Showing
5 changed files
with
138 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
package resource | ||
|
||
import ( | ||
"errors" | ||
"regexp" | ||
|
||
"github.com/cppforlife/go-semi-semantic/version" | ||
) | ||
|
||
func FilterVersions(versions []Version, predicateString string) ([]Version, error) { | ||
if predicateString == "" { | ||
return versions, nil | ||
} | ||
|
||
predicate, err := ParsePredicate(predicateString) | ||
if err != nil { | ||
return []Version{}, err | ||
} | ||
|
||
var filteredVersions []Version | ||
|
||
for _, version := range versions { | ||
if predicate.Apply(version) { | ||
filteredVersions = append(filteredVersions, version) | ||
} | ||
} | ||
|
||
return filteredVersions, err | ||
} | ||
|
||
type VersionPredicate struct { | ||
Condition string | ||
Version string | ||
} | ||
|
||
func ParsePredicate(filter string) (VersionPredicate, error) { | ||
re, err := regexp.Compile(`(<)\s*(.*)`) | ||
if err != nil { | ||
return VersionPredicate{}, err | ||
} | ||
|
||
matches := re.FindAllStringSubmatch(filter, -1) | ||
if len(matches) != 1 || len(matches[0]) != 3 { | ||
return VersionPredicate{}, errors.New("Invalid version filter") | ||
} | ||
|
||
return VersionPredicate{Condition: matches[0][1], Version: matches[0][2]}, nil | ||
} | ||
|
||
func (p VersionPredicate) Apply(version Version) bool { | ||
return lessThan(version, Version{Tag: p.Version}) | ||
} | ||
|
||
func lessThan(v1, v2 Version) bool { | ||
first, err := version.NewVersionFromString(determineVersionFromTag(v1.Tag)) | ||
if err != nil { | ||
return true | ||
} | ||
|
||
second, err := version.NewVersionFromString(determineVersionFromTag(v2.Tag)) | ||
if err != nil { | ||
return false | ||
} | ||
|
||
return first.IsLt(second) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
package resource_test | ||
|
||
import ( | ||
. "github.com/onsi/ginkgo" | ||
. "github.com/onsi/gomega" | ||
|
||
. "github.com/concourse/github-release-resource" | ||
) | ||
|
||
var _ = Describe("VersionUtils", func() { | ||
Describe("FilterVersion", func() { | ||
It("should filter list of versions by tag", func() { | ||
inputVersions := []Version{{Tag: "0.1.1"}, {Tag: "0.2.1"}, {Tag: "0.3.0"}, {Tag: "0.3.1"}} | ||
versions, err := FilterVersions(inputVersions, "< 0.3.0") | ||
Expect(err).ToNot(HaveOccurred()) | ||
Expect(versions).To(Equal([]Version{{Tag: "0.1.1"}, {Tag: "0.2.1"}})) | ||
}) | ||
Context("When filter is blank", func() { | ||
It("should return the input versions", func() { | ||
inputVersions := []Version{{Tag: "0.1.1"}, {Tag: "0.2.1"}, {Tag: "0.3.0"}, {Tag: "0.3.1"}} | ||
versions, err := FilterVersions(inputVersions, "") | ||
Expect(err).ToNot(HaveOccurred()) | ||
Expect(versions).To(Equal(inputVersions)) | ||
}) | ||
}) | ||
}) | ||
|
||
Describe("VersionFilter", func() { | ||
Describe("ParsePredicate", func() { | ||
It("should parse a '<' filter", func() { | ||
filter, err := ParsePredicate("< 3.1.1") | ||
Expect(err).ToNot(HaveOccurred()) | ||
Expect(filter).To(Equal(VersionPredicate{Condition: "<", Version: "3.1.1"})) | ||
}) | ||
}) | ||
}) | ||
|
||
Describe("Apply", func() { | ||
It("should determine if the given versions bool value", func() { | ||
predicate := VersionPredicate{Condition: "<", Version: "4.0.0"} | ||
Expect(predicate.Apply(Version{Tag: "3.9.9"})).To(Equal(true)) | ||
}) | ||
}) | ||
}) |