[14.0][ADD] sale_certificat_typology #281

chafique-delli · 2023-09-20T18:18:02Z

No description provided.

codecov · 2023-09-20T18:22:39Z

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (a69b8b3) 75.83% compared to head (96ee09c) 80.54%.
Report is 45 commits behind head on 14.0.

❗ Current head 96ee09c differs from pull request most recent head 9cdfd90. Consider uploading reports for the commit 9cdfd90 to get more accurate results

Files	Patch %	Lines
sale_certificat_typology/models/sale_order.py	76.19%	8 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             14.0     #281      +/-   ##
==========================================
+ Coverage   75.83%   80.54%   +4.70%     
==========================================
  Files          83      130      +47     
  Lines         927     1444     +517     
  Branches      181      276      +95     
==========================================
+ Hits          703     1163     +460     
- Misses        194      240      +46     
- Partials       30       41      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chafique-delli · 2023-09-26T08:16:16Z

@Kev-Roche
@sebastienbeau

Kev-Roche · 2023-09-29T13:15:11Z

sale_certificat_typology/models/sale_order.py

+        comodel_name="certificat.typology", string="Certificat typology", required=True
+    )
+    certificat = fields.Binary(string="Certificat", attachment=True)
+    certificat_is_ok = fields.Boolean(string="Is valid ?")


Actually, we can validate a certificate without uploading a certificate. Maybe hide the boolean in view or unallow to validate if no certificate ?

@Kev-Roche , it's fixed.

Kev-Roche · 2023-09-29T13:22:49Z

On the sale order, we don't have information about which product(s) required a certificate. Maybe add the product name in the certificate page on each certificate line ?

chafique-delli · 2023-10-04T09:46:25Z

On the sale order, we don't have information about which product(s) required a certificate. Maybe add the product name in the certificate page on each certificate line ?

@Kev-Roche , it's done.

chafique-delli · 2023-10-13T08:23:28Z

@Kev-Roche , the changes made, are ok for you?

sebastienbeau · 2023-11-27T14:57:43Z

sale_certificat_typology/models/product.py

+    @api.model_create_multi
+    def create(self, vals_list):
+        templates = super().create(vals_list)
+        for template, vals in zip(templates, vals_list):
+            if "required_certificat_ids" in vals:
+                template.product_variant_ids.write(
+                    {"required_certificat_ids": vals["required_certificat_ids"]}
+                )
+        return templates
+
+    def write(self, vals):
+        res = super().write(vals)
+        if "required_certificat_ids" in vals:
+            self.product_variant_ids.write(
+                {"required_certificat_ids": vals["required_certificat_ids"]}
+            )
+        return res
+
+
+class ProductProduct(models.Model):
+    _inherit = "product.product"
+
+    required_certificat_ids = fields.Many2many(
+        comodel_name="certificat.typology",
+        string="Requested certificats",
+    )


Maybe I am wrong, but the certificat should be required for all variant. So we do not need this code

Suggested change

@api.model_create_multi

def create(self, vals_list):

templates = super().create(vals_list)

for template, vals in zip(templates, vals_list):

if "required_certificat_ids" in vals:

template.product_variant_ids.write(

{"required_certificat_ids": vals["required_certificat_ids"]}

)

return templates

def write(self, vals):

res = super().write(vals)

if "required_certificat_ids" in vals:

self.product_variant_ids.write(

{"required_certificat_ids": vals["required_certificat_ids"]}

)

return res

class ProductProduct(models.Model):

_inherit = "product.product"

required_certificat_ids = fields.Many2many(

comodel_name="certificat.typology",

string="Requested certificats",

)

sebastienbeau · 2023-11-27T16:22:54Z

sale_certificat_typology/models/sale_order.py

+class SaleOrder(models.Model):
+    _inherit = "sale.order"
+
+    certificat_item_ids = fields.One2many(


@api.depends("order_line.product_id") def _compute_certificat_item_ids(self): for record in self: required_certs = record.order_line.product_id.required_certificat_ids items = record.certificat_item_ids.filtered(lamda s: s.typology_id in required_certs) for cert in required_certs: if cert not in items.typology_id: items |= self.env["sale.order.certificat.item"].new({ "typology_id": cert.id, }) record.certificat_item_ids = items

@sebastienbeau , I made the suggested changes.

sebastienbeau · 2023-11-27T16:26:28Z

sale_certificat_typology/models/sale_order.py

+    product_ids = fields.Many2many(
+        comodel_name="product.product",
+        string="Concerned products",
+        compute="_compute_product_ids",
+        readonly=False,
+    )


remove, just add the related required_certificat_ids on sale.order.line with optional="hide"

@sebastienbeau , I made the suggested changes.

sebastienbeau · 2023-11-27T16:26:49Z

sale_certificat_typology/models/sale_order.py

+    order_line_ids = fields.Many2many(
+        comodel_name="sale.order.line", string="Linked order lines", required=True
+    )


@sebastienbeau , I made the suggested changes.

github-grap-bot added the needs review label Sep 20, 2023

Kev-Roche reviewed Sep 29, 2023

View reviewed changes

chafique-delli force-pushed the 14.0-ADD-sale_certificat_typology branch 2 times, most recently from 18d54f5 to f24b1bd Compare October 4, 2023 09:44

[14.0][ADD] sale_certificat_typology

f6af44a

chafique-delli force-pushed the 14.0-ADD-sale_certificat_typology branch from f24b1bd to f6af44a Compare October 5, 2023 08:55

sebastienbeau requested changes Nov 27, 2023

View reviewed changes

chafique-delli force-pushed the 14.0-ADD-sale_certificat_typology branch from cae5511 to 96ee09c Compare December 1, 2023 18:32

code refactor and simplification

83a13ad

chafique-delli force-pushed the 14.0-ADD-sale_certificat_typology branch from 96ee09c to 83a13ad Compare December 6, 2023 09:44

add code field in certificat typology'

9cdfd90

Kev-Roche force-pushed the 14.0-ADD-sale_certificat_typology branch from 157f367 to 9cdfd90 Compare October 29, 2024 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][ADD] sale_certificat_typology #281

[14.0][ADD] sale_certificat_typology #281

chafique-delli commented Sep 20, 2023

codecov bot commented Sep 20, 2023 •

edited

Loading

chafique-delli commented Sep 26, 2023

Kev-Roche Sep 29, 2023

chafique-delli Oct 3, 2023

Kev-Roche commented Sep 29, 2023

chafique-delli commented Oct 4, 2023

chafique-delli commented Oct 13, 2023

sebastienbeau Nov 27, 2023

sebastienbeau Nov 27, 2023

chafique-delli Dec 1, 2023

sebastienbeau Nov 27, 2023

chafique-delli Dec 1, 2023

sebastienbeau Nov 27, 2023

chafique-delli Dec 1, 2023

[14.0][ADD] sale_certificat_typology #281

Are you sure you want to change the base?

[14.0][ADD] sale_certificat_typology #281

Conversation

chafique-delli commented Sep 20, 2023

codecov bot commented Sep 20, 2023 • edited Loading

Codecov Report

chafique-delli commented Sep 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kev-Roche commented Sep 29, 2023

chafique-delli commented Oct 4, 2023

chafique-delli commented Oct 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Sep 20, 2023 •

edited

Loading