Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] purchase_requisition_proposal module #256

Open
wants to merge 6 commits into
base: 14.0
Choose a base branch
from

Conversation

Kev-Roche
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Merging #256 (8d8da15) into 14.0 (cd14ada) will increase coverage by 4.75%.
Report is 41 commits behind head on 14.0.
The diff coverage is 86.33%.

❗ Current head 8d8da15 differs from pull request most recent head d674918. Consider uploading reports for the commit d674918 to get more accurate results

@@            Coverage Diff             @@
##             14.0     #256      +/-   ##
==========================================
+ Coverage   75.81%   80.56%   +4.75%     
==========================================
  Files          83       98      +15     
  Lines         922     1276     +354     
  Branches      177      241      +64     
==========================================
+ Hits          699     1028     +329     
- Misses        195      206      +11     
- Partials       28       42      +14     
Files Changed Coverage Δ
...st_per_attribute_value/models/product_pricelist.py 67.34% <29.41%> (+1.43%) ⬆️
...equisition_proposal/models/purchase_requisition.py 69.62% <69.62%> (ø)
...ition_proposal/models/purchase_requisition_line.py 80.00% <80.00%> (ø)
...ion_proposal/wizard/wizard_requisition_proposal.py 87.50% <87.50%> (ø)
...l/models/purchase_requisition_information_mixin.py 90.00% <90.00%> (ø)
...n_proposal/models/purchase_requisition_proposal.py 94.59% <94.59%> (ø)
purchase_requisition_proposal/__init__.py 100.00% <100.00%> (ø)
purchase_requisition_proposal/models/__init__.py 100.00% <100.00%> (ø)
purchase_requisition_proposal/models/ir_config.py 100.00% <100.00%> (ø)
...hase_requisition_proposal/models/purchase_order.py 100.00% <100.00%> (ø)
... and 6 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Kev-Roche Kev-Roche force-pushed the 14.0_add_purchase_requisition_proposal branch 9 times, most recently from f04a899 to 3d6fb0c Compare January 12, 2023 23:54
@rvalyi
Copy link
Member

rvalyi commented Jan 13, 2023

Hello @Kev-Roche I think we need to review a bit this module because it may overlap a bit with this module https://github.com/akretion/purchase-workflow/tree/12.0-purchase-requisition-selection/purchase_requisition_selection
we did for the Jung industry here in Brazil. It works very well in production since 2020 and we plan to migrate it this year to v14 or possibly even to v16. May be we should have a short call about this?

In the original purchase_requisition module, a proposal, or a bid is actually a purchase.order.line and this is what we use for bids in purchase_requisition_selection.

cc @sebastienbeau @renatonlima @clementmbr

@Kev-Roche
Copy link
Member Author

@rvalyi we can discuss about it, but we ll keep this module in incubator for a moment.

@Kev-Roche Kev-Roche force-pushed the 14.0_add_purchase_requisition_proposal branch from 3d6fb0c to 28ac486 Compare January 16, 2023 23:05
@Kev-Roche Kev-Roche force-pushed the 14.0_add_purchase_requisition_proposal branch from 28ac486 to 8a05c65 Compare January 19, 2023 14:06
@Kev-Roche Kev-Roche force-pushed the 14.0_add_purchase_requisition_proposal branch 6 times, most recently from 774a7e3 to 8b18fa1 Compare February 22, 2023 09:03
@Kev-Roche Kev-Roche marked this pull request as draft February 22, 2023 22:25
@Kev-Roche Kev-Roche force-pushed the 14.0_add_purchase_requisition_proposal branch from 8b18fa1 to dbd0fc2 Compare February 24, 2023 14:57
@Kev-Roche Kev-Roche force-pushed the 14.0_add_purchase_requisition_proposal branch 2 times, most recently from 5fe16bd to f6a013f Compare February 27, 2023 10:26
@Kev-Roche Kev-Roche force-pushed the 14.0_add_purchase_requisition_proposal branch 3 times, most recently from e788161 to 577e34a Compare March 2, 2023 12:58
@Kev-Roche Kev-Roche force-pushed the 14.0_add_purchase_requisition_proposal branch 3 times, most recently from c390108 to 0105c6b Compare March 17, 2023 10:15
@Kev-Roche Kev-Roche force-pushed the 14.0_add_purchase_requisition_proposal branch from 0105c6b to 902d259 Compare March 20, 2023 18:44
@Kev-Roche Kev-Roche force-pushed the 14.0_add_purchase_requisition_proposal branch from ac28b01 to dedbf29 Compare August 1, 2023 14:07
@Kev-Roche Kev-Roche force-pushed the 14.0_add_purchase_requisition_proposal branch from dedbf29 to d674918 Compare September 4, 2023 15:04
@sebastienbeau sebastienbeau marked this pull request as ready for review October 17, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants