Merge pull request #283 from akretion/16-refund-no-business-field

[16][ADD] account_refund_no_business_field

account_refund_no_business_field/README.rst

@@ -0,0 +1,79 @@
+================================
+Account Refund No Business Field
+================================
+
+.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! This file is generated by oca-gen-addon-readme !!
+   !! changes will be overwritten.                   !!
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
+    :target: https://odoo-community.org/page/development-status
+    :alt: Beta
+.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
+    :alt: License: AGPL-3
+.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fak--odoo--incubator-lightgray.png?logo=github
+    :target: https://github.com/OCA/ak-odoo-incubator/tree/16.0/account_refund_no_business_field
+    :alt: OCA/ak-odoo-incubator
+.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
+    :target: https://translation.odoo-community.org/projects/ak-odoo-incubator-16-0/ak-odoo-incubator-16-0-account_refund_no_business_field
+    :alt: Translate me on Weblate
+.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
+    :target: https://runboat.odoo-community.org/webui/builds.html?repo=OCA/ak-odoo-incubator&target_branch=16.0
+    :alt: Try me on Runboat
+
+|badge1| |badge2| |badge3| |badge4| |badge5| 
+
+When creating a refund with a different mode than 'modify' (Full refund and new draft invoice), avoid copying business fields (which are the link between invoice lines and sale or purchase lines in native Odoo).
+These business fields impact the quantity invoiced on sale and purchase order lines, decreasing it.
+
+The main case this modules aims to fix is the following : 
+A sale order is fully invoiced. A refund is made on this invoice, the quantity invoiced is decreased and the invoicing state of the sale order goes back to "to invoice".
+Then, a second invoice may be generated.
+This is especially an issue when using sale_automatic_workflow with automatic invoice creation.
+
+**Table of contents**
+
+.. contents::
+   :local:
+
+Bug Tracker
+===========
+
+Bugs are tracked on `GitHub Issues <https://github.com/OCA/ak-odoo-incubator/issues>`_.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us smashing it by providing a detailed and welcomed
+`feedback <https://github.com/OCA/ak-odoo-incubator/issues/new?body=module:%20account_refund_no_business_field%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+
+Do not contact contributors directly about support or help with technical issues.
+
+Credits
+=======
+
+Authors
+~~~~~~~
+
+* Akretion
+
+Contributors
+~~~~~~~~~~~~
+
+* Florian da Costa <[email protected]>
+
+Maintainers
+~~~~~~~~~~~
+
+This module is maintained by the OCA.
+
+.. image:: https://odoo-community.org/logo.png
+   :alt: Odoo Community Association
+   :target: https://odoo-community.org
+
+OCA, or the Odoo Community Association, is a nonprofit organization whose
+mission is to support the collaborative development of Odoo features and
+promote its widespread use.
+
+This module is part of the `OCA/ak-odoo-incubator <https://github.com/OCA/ak-odoo-incubator/tree/16.0/account_refund_no_business_field>`_ project on GitHub.
+
+You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

account_refund_no_business_field/__init__.py

@@ -0,0 +1,2 @@
+from . import models
+from . import wizards

account_refund_no_business_field/__manifest__.py

@@ -0,0 +1,16 @@
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+{
+    "name": "Account Refund No Business Field",
+    "version": "16.0.1.0.0",
+    "category": "Sale",
+    "author": "Akretion,Odoo Community Association (OCA)",
+    "website": "https://github.com/akretion/ak-odoo-incubator",
+    "license": "AGPL-3",
+    "depends": [
+        "account",
+        # this is a functional dependency
+        "sale",
+    ],
+    "installable": True,
+}

account_refund_no_business_field/models/__init__.py

@@ -0,0 +1 @@
+from . import account_move_line

account_refund_no_business_field/models/account_move_line.py

@@ -0,0 +1,13 @@
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+
+from odoo import models
+
+
+class AccountMoveLine(models.Model):
+    _inherit = "account.move.line"
+
+    def _copy_data_extend_business_fields(self, values):
+        if self.env.context.get("refund_mode", "") in ("refund", "cancel"):
+            return
+        return super()._copy_data_extend_business_fields(values)

account_refund_no_business_field/readme/CONTRIBUTORS.rst

@@ -0,0 +1 @@
+* Florian da Costa <[email protected]>

account_refund_no_business_field/readme/DESCRIPTION.rst

@@ -0,0 +1,7 @@
+When creating a refund with a different mode than 'modify' (Full refund and new draft invoice), avoid copying business fields (which are the link between invoice lines and sale or purchase lines in native Odoo).
+These business fields impact the quantity invoiced on sale and purchase order lines, decreasing it.
+
+The main case this modules aims to fix is the following :
+A sale order is fully invoiced. A refund is made on this invoice, the quantity invoiced is decreased and the invoicing state of the sale order goes back to "to invoice".
+Then, a second invoice may be generated.
+This is especially an issue when using sale_automatic_workflow with automatic invoice creation.

account_refund_no_business_field/readme/ROADMAP.rst

@@ -0,0 +1 @@
+With this module, if you create a refund on a sale order invoice, it won't be link to the sale order (it won't be visible from the sale order in the UI)