Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify detach_on_error #247

Merged
merged 1 commit into from
Sep 13, 2024
Merged

docs: clarify detach_on_error #247

merged 1 commit into from
Sep 13, 2024

Conversation

kivra-mikgra
Copy link
Contributor

Change description

What problem does this solve?

Issue number: (if applicable)

Example usage

Additional details and screenshots

Checklist

  • I have added unit tests to cover my changes.
  • I have added documentation to cover my changes.
  • My changes have passed unit tests and have been tested E2E in an example project.

@kivra-mikgra
Copy link
Contributor Author

In my opinion the wording in the previous documentation makes you think that true will let the MFA to continue to be invoked after a fail.

@coveralls
Copy link

Coverage Status

coverage: 76.931% (-0.2%) from 77.131%
when pulling 15a39bb on kivra-mikgra:patch-1
into 6f97943 on akoutmos:master.

@akoutmos akoutmos merged commit 82e99b5 into akoutmos:master Sep 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kivra-mikgra @coveralls @akoutmos