Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated benchmarks on i7 and Edison #44

Closed
wants to merge 4 commits into from
Closed

Updated benchmarks on i7 and Edison #44

wants to merge 4 commits into from

Conversation

htot
Copy link
Contributor

@htot htot commented Oct 21, 2017 •
edited
Loading

I also reran benchmarks at earlier commits to track improvement/degradation in coding/decoding speeds.

Strangely it looks like Edison SSE Decode has degraded by recent commits to the level of Plain. The same commit is creating an improvement on i7.

The exact commit causing this is 0a69845. It reduced SSE3 decode on Edison from 207 -> 146

Very strange.

htot added 4 commits October 20, 2017 21:57
@htot
benchmarks: updated results after recent optimizations
ffc9548 
Results measured using commit @0a698455

Signed-off-by: Ferry Toth <[email protected]>
On branch master
	modified:   README.md
no changes added to commit (use "git add" and/or "git commit -a")

Signed-off-by: Ferry Toth <[email protected]>
On branch master
	modified:   README.md
no changes added to commit (use "git add" and/or "git commit -a")

Signed-off-by: Ferry Toth <[email protected]>
On branch master
	modified:   README.md
no changes added to commit (use "git add" and/or "git commit -a")

Signed-off-by: Ferry Toth <[email protected]>
@htot
benchmarks: codec speed development and regressions over time
cd04b24 
Signed-off-by: Ferry Toth <[email protected]>
@htot
benchmarks: fix image sizes
79a00a1 
Signed-off-by: Ferry Toth <[email protected]>
On branch master
	modified:   README.md
no changes added to commit (use "git add" and/or "git commit -a")

Signed-off-by: Ferry Toth <[email protected]>
@htot
benchmarks: clean up
b0f5700 
Signed-off-by: Ferry Toth <[email protected]>
@htot htot mentioned this pull request Oct 29, 2017
Closed
@aqrit aqrit mentioned this pull request Nov 25, 2017
Closed
@aklomp
Copy link
Owner

aklomp commented Nov 23, 2019

Hey, sorry for the late response to this PR. Unfortunately I decided not to merge it, for the following reasons:

  • As far as I can tell, the PR does not come with a way to regenerate these graphs from the data, or to generate additional graphs. Something like a Makefile would be nice.
  • I'm not in favor of committing large binary blobs to this repo. Git doesn't like them, and it's not very friendly to users. The graphs should be in SVG format.
  • The benchmarks themselves are, or will be, obsolete soon. I'm working on some substantial performance improvements, see Encoders: turn into proper inline functions #58 and Decoders: turn into proper inline functions #59.
  • In my opinion, these images should be stored in tests/benchmarks/images, not in a new toplevel directory.

I've been thinking about how we store and display the benchmark results, and created issue #60 to track my thoughts. You're welcome to join that discussion!

@aklomp aklomp closed this Nov 23, 2019
@htot
Copy link
Contributor Author

htot commented Nov 23, 2019

The performance degradation on Atom (Silvermont) was the real news.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@htot @aklomp