sample: Akka Projections 1.5.1 in samples #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
commented
Dec 20, 2023
| @@ -96,7 +96,6 @@ object ChargingStation { | |||
| def init(implicit system: ActorSystem[_]): Replication[Command] = { | |||
| val replicationSettings = | |||
| ReplicationSettings[Command](EntityType, R2dbcReplication()) | |||
| // FIXME remove once release out with flag in config (1.5.1-M2/GA) | |||
There was a problem hiding this comment.
was there some other intention with this FIXME? should it be via config accept-edge-replication instead?
There was a problem hiding this comment.
That was the idea, but I think using the API might be good for extra clarity in the sample anyway, so let's leave it like this.
patriknw
changed the title
johanandren
approved these changes
Dec 20, 2023
| @@ -96,7 +96,6 @@ object ChargingStation { | |||
| def init(implicit system: ActorSystem[_]): Replication[Command] = { | |||
| val replicationSettings = | |||
| ReplicationSettings[Command](EntityType, R2dbcReplication()) | |||
| // FIXME remove once release out with flag in config (1.5.1-M2/GA) | |||
There was a problem hiding this comment.
That was the idea, but I think using the API might be good for extra clarity in the sample anyway, so let's leave it like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to bump this before making the release, otherwise the sample zip files will contain the old version.