fix: support PostgreSQL (added with NodeBB v1.10.x) #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all thanks for your work! I'm helping with the move of forum from IPBoard to NodeBB, and without your modules it would take a LOT more time (or would not happen at all).
I noticed that there was no
db.keysmethod for PostgreSQL implemented in your code. There isdb.scanhowever in NodeBB 1.12.1, which seems to do exactly the same. So i added fallback to it, and then another fallback for postgres, just in case (i did not test that one really, but it's close to what postgres handler does in NodeBB'sdb.scan).Regards